From: Arnout Vandecappelle <arnout@mind.be>
To: Edgar Bonet <bonet@grenoble.cnrs.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/kconfig: fix compiler warnings
Date: Wed, 6 Oct 2021 21:23:47 +0200 [thread overview]
Message-ID: <62f5735f-8b4e-c807-1ba5-0c0ff68f4dfd@mind.be> (raw)
In-Reply-To: <2426ca2d-7fa8-d8a1-c542-0abbfcec3ec8@grenoble.cnrs.fr>
On 22/09/2021 16:08, Edgar Bonet wrote:
> Compiling on Ubuntu 20.04 generates this:
>
> ./util.c: In function ‘file_write_dep’
> ./util.c:54:18: warning: ‘..config.tmp’ directive writing 12 bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
> 54 | sprintf(buf, "%s..config.tmp", dir);
> | ^~~~~~~~~~~~
> ./util.c:54:2: note: ‘sprintf’ output between 13 and 4109 bytes into a destination of size 4097
> 54 | sprintf(buf, "%s..config.tmp", dir);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> and similar warnings on confdata.c, lines 778, 989, 995, 1000, 1007,
> 1040, 1046 and 1054. Avoid the warnings by enlarging the destination
> buffer of fprintf().
>
> Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>
> ---
> support/kconfig/confdata.c | 4 ++--
> support/kconfig/util.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Normally, when we make changes to the kconfig sources, we want to keep track
of that with patches in support/kconfig/patches. This allows us to track
upstream without loosing the modifications we make.
However, in this case, upstream has already heavily modified those files, and
fixed the issues. So we there's no need to keep it as patches.
Therefore, applied to master, with an updated commit message that explains the
above, thanks.
Regards,
Arnout
>
> diff --git a/support/kconfig/confdata.c b/support/kconfig/confdata.c
> index 892da74fdc..9ab980edd8 100644
> --- a/support/kconfig/confdata.c
> +++ b/support/kconfig/confdata.c
> @@ -744,7 +744,7 @@ int conf_write(const char *name)
> struct menu *menu;
> const char *basename;
> const char *str;
> - char dirname[PATH_MAX+1], tmpname[PATH_MAX+1], newname[PATH_MAX+1];
> + char dirname[PATH_MAX+1], tmpname[PATH_MAX+20], newname[PATH_MAX+1];
> char *env;
>
> if (!name)
> @@ -974,7 +974,7 @@ int conf_write_autoconf(void)
> const char *name;
> FILE *out, *tristate, *out_h;
> int i;
> - char dir[PATH_MAX+1], buf[PATH_MAX+1];
> + char dir[PATH_MAX+1], buf[PATH_MAX+20];
> char *s;
>
> strcpy(dir, conf_get_configname());
> diff --git a/support/kconfig/util.c b/support/kconfig/util.c
> index 18a8e52391..8665f5bb89 100644
> --- a/support/kconfig/util.c
> +++ b/support/kconfig/util.c
> @@ -35,7 +35,7 @@ struct file *file_lookup(const char *name)
> int file_write_dep(const char *name)
> {
> char *str;
> - char buf[PATH_MAX+1], buf2[PATH_MAX+1], dir[PATH_MAX+1];
> + char buf[PATH_MAX+20], buf2[PATH_MAX+1], dir[PATH_MAX+1];
> struct symbol *sym, *env_sym;
> struct expr *e;
> struct file *file;
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-06 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 14:08 [Buildroot] [PATCH 1/1] support/kconfig: fix compiler warnings Edgar Bonet
2021-10-06 19:23 ` Arnout Vandecappelle [this message]
2021-10-07 6:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62f5735f-8b4e-c807-1ba5-0c0ff68f4dfd@mind.be \
--to=arnout@mind.be \
--cc=bonet@grenoble.cnrs.fr \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).