From: Arnout Vandecappelle <arnout@mind.be>
To: Juergen Stuber <juergen@jstuber.net>, buildroot@buildroot.org
Cc: Romain Naour <romain.naour@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH 1/1] toolchain/toolchain-external: Allow relative paths in BR2_TOOLCHAIN_EXTERNAL_PATH.
Date: Tue, 8 Feb 2022 21:56:08 +0100 [thread overview]
Message-ID: <6d74e1be-2ff0-5e4d-cf2d-1e2b078162c1@mind.be> (raw)
In-Reply-To: <20210527145118.31373-1-juergen@jstuber.net>
On 27/05/2021 16:51, Juergen Stuber wrote:
> Convert BR2_TOOLCHAIN_EXTERNAL_PATH to an absolute path when used.
>
> Otherwise the symbolic links to the external toolchain binaries are
> not installed in host/bin when BR2_TOOLCHAIN_EXTERNAL_PATH is relative.
> This happens because TOOLCHAIN_EXTERNAL_INSTALL_WRAPPER
> changes directory into host/bin to create the symbolic links.
> From there the tools are no longer found via the relative path and
> a single symbolic link host/bin/$(prefix)-* is created instead.
I've extended the commit message a bit to explain a use case where relative
paths may be useful, and applied to master, thanks.
Regards,
Arnout
>
> Signed-off-by: Juergen Stuber <juergen@jstuber.net>
> ---
> toolchain/toolchain-external/pkg-toolchain-external.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index 6d91cb5d1e..2b70007a34 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -68,7 +68,7 @@ TOOLCHAIN_EXTERNAL_DOWNLOAD_INSTALL_DIR = $(HOST_DIR)/opt/ext-toolchain
> ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y)
> TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(TOOLCHAIN_EXTERNAL_DOWNLOAD_INSTALL_DIR)
> else
> -TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PATH))
> +TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(abspath $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PATH)))
> endif
>
> ifeq ($(TOOLCHAIN_EXTERNAL_INSTALL_DIR),)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-02-08 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 14:51 [Buildroot] [PATCH 1/1] toolchain/toolchain-external: Allow relative paths in BR2_TOOLCHAIN_EXTERNAL_PATH Juergen Stuber
2022-01-08 18:25 ` Romain Naour
2022-02-08 20:56 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d74e1be-2ff0-5e4d-cf2d-1e2b078162c1@mind.be \
--to=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=juergen@jstuber.net \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).