From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Alexandru Ardelean <ardeleanalex@gmail.com>,
Angelo Compagnucci <angelo.compagnucci@gmail.com>,
Daniel Price <daniel.price@gmail.com>,
Martin Bark <martin@barkynet.com>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/4] package/nodejs: fixup qemu dependencies
Date: Tue, 11 Oct 2022 20:53:46 +0200 [thread overview]
Message-ID: <877d16p4xx.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220925171932.1630739-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Sun, 25 Sep 2022 19:19:29 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Commit 1facb09b94bf806b301868539185c0ff9ddffee2 ("package/nodejs:
> build host-nodejs only if we're installing modules with NPM") forgot
> to account for the dependency on Qemu. Now that nodejs no longer
> depends on host-nodejs, but needs host-qemu, we need to make sure that
> nodejs selects the relevant BR2_PACKAGE_HOST_QEMU options.
> So this patch:
> - Drops the dependency of BR2_PACKAGE_NODEJS_ARCH_SUPPORTS on
> BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET, which was incorrect: we
> don't care about running Qemu on the target. We care about
> host-qemu supporting the emulation of the target architecture,
> which is what BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS is for.
> - Adds the dependency to the relevant BR2_PACKAGE_HOST_QEMU options
> to BR2_PACKAGE_NODEJS, so that host-qemu is built with the
> appropriate features needed to build the target nodejs.
> - Removes the qemu related dependencies from host-nodejs, which does
> not need Qemu at all.
> Without this change the build of nodejs without npm enabled is broken
> as the host-qemu that gets built does not have all the features that
> are needed. There are no autobuild failures at this point, however.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2022.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-10-11 18:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 17:19 [Buildroot] [PATCH 1/4] package/nodejs: fixup qemu dependencies Thomas Petazzoni
2022-09-25 17:19 ` [Buildroot] [PATCH 2/4] package/nodejs: bump to v16.17.1 Thomas Petazzoni via buildroot
2022-09-25 18:17 ` Yann E. MORIN
2022-10-11 19:19 ` Peter Korsgaard
2022-10-12 8:26 ` Peter Korsgaard
2022-10-14 19:33 ` Yann E. MORIN
2022-09-25 17:19 ` [Buildroot] [PATCH 3/4] package/nodejs: add patch to adjust default NodeJS search path Thomas Petazzoni
2022-09-25 18:15 ` Yann E. MORIN
2022-09-25 19:23 ` Thomas Petazzoni
2022-09-25 17:19 ` [Buildroot] [PATCH 4/4] support/testing/tests: add NodeJS tests Thomas Petazzoni
2022-09-25 18:16 ` [Buildroot] [PATCH 1/4] package/nodejs: fixup qemu dependencies Yann E. MORIN
2022-10-11 18:53 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d16p4xx.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=angelo.compagnucci@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).