From: Peter Korsgaard <peter@korsgaard.com>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: buildroot@busybox.net, Sergey Matyukevich <geomatsi@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/3] boot/arm-trusted-firmware: fix SSP support
Date: Mon, 17 Oct 2022 10:34:14 +0200 [thread overview]
Message-ID: <87a65uc0hl.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <96728725434424ecdff6a4087126c9d665c877ec.1665496931.git.baruch@tkos.co.il> (Baruch Siach via buildroot's message of "Tue, 11 Oct 2022 17:02:09 +0300")
>>>>> "Baruch" == Baruch Siach via buildroot <buildroot@buildroot.org> writes:
> Commit ccac9a5bbbd ("boot/arm-trusted-firmware: don't force
> ENABLE_STACK_PROTECTOR") fixed a build failure but also effectively
> disabled SSP entirely for ATF. This is because ENABLE_STACK_PROTECTOR is
> set to 0 unconditionally in make_helpers/defaults.mk, overwriting any
> environment set value. So we must pass ENABLE_STACK_PROTECTOR in
> MAKE_OPTS for it to be effective. But to avoid said build failure we
> can't pass ENABLE_STACK_PROTECTOR=0.
> Only pass ENABLE_STACK_PROTECTOR when
> BR2_TARGET_ARM_TRUSTED_FIRMWARE_SSP is enabled. Drop SSP_LEVEL value for
> the !BR2_TARGET_ARM_TRUSTED_FIRMWARE_SSP case which is now unused.
> Cc: Dick Olsson <hi@senzilla.io>
> Cc: Sergey Matyukevich <geomatsi@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Heh, I just spent some time investigating some ATF link failures for
avenger96_defconfig after we moved to glibc by default (which enables
SSP support) and got to the same conclusion ;)
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-17 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 14:02 [Buildroot] [PATCH 1/3] boot/arm-trusted-firmware: fix SSP support Baruch Siach via buildroot
2022-10-11 14:02 ` [Buildroot] [PATCH 2/3] configs/solidrun_{macchiatobin, clearfog_gt_8k}: disable SSP Baruch Siach via buildroot
2022-10-17 8:34 ` Peter Korsgaard
2022-10-11 14:02 ` [Buildroot] [PATCH 3/3] boot/mv-ddr-marvell: " Baruch Siach via buildroot
2022-10-17 8:34 ` Peter Korsgaard
2022-11-02 22:46 ` Peter Korsgaard
2022-10-17 8:34 ` Peter Korsgaard [this message]
2022-11-02 22:45 ` [Buildroot] [PATCH 1/3] boot/arm-trusted-firmware: fix SSP support Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a65uc0hl.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=buildroot@busybox.net \
--cc=geomatsi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).