From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] package/nodejs: improve 0001-add-qemu-wrapper-support.patch to fix build issue
Date: Tue, 11 Oct 2022 20:48:13 +0200 [thread overview]
Message-ID: <87fsfup576.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220925082044.445AB85FCD@busybox.osuosl.org> (Thomas Petazzoni's message of "Sun, 25 Sep 2022 10:19:12 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=cf0ddc89705af989393b1601bbf57d567a9a1b13
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> Since upstream commit 79da2534737bd090b7000beed68d225618606e53,
> present since NodeJS 16.0.0, another call to the torque tool is done
> in tools/v8_gypfiles/v8.gyp, but our patch to wrap calls to such tools
> under Qemu forgot this addition. Due to this, the build of NodeJS is
> broken since the bump to v16 in Buildroot commit
> 07408779cc068041a2da6838fe077d1a679f1736 ("package/nodejs: bump to
> 16.15.0"). This issue is not visible in the autobuilders as it was
> hidden by a previous build issue, itself fixed by "package/nodejs: fix
> 'Duplicate v8 target errors when cross-compiling' error".
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2022.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-10-11 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 8:19 [Buildroot] [git commit] package/nodejs: improve 0001-add-qemu-wrapper-support.patch to fix build issue Thomas Petazzoni
2022-10-11 18:48 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsfup576.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).