From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/pkg-meson: ensure the global cross-compilation.conf file is correct
Date: Tue, 15 Sep 2020 21:03:09 +0200 [thread overview]
Message-ID: <87pn6mrhg2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200914200407.GB8792@scaer> (Yann E. MORIN's message of "Mon, 14 Sep 2020 22:04:07 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Thomas?, All,
> On 2019-12-04 16:02 +0100, Thomas Petazzoni spake thusly:
>> Currently, the cross-compilation.conf installed in
>> $(HOST_DIR)/etc/meson/cross-compilation.conf for use by the SDK is
>> generated in a post-install-staging hook of the toolchain package.
>>
>> With per-package directory support enabled, this means that the
>> generated cross-compilation.conf contains references to the
>> per-package directory of the toolchain/ package, which is not want we
>> want:
>>
>> [binaries]
>> c = '/home/thomas/projets/buildroot/output/per-package/toolchain/host/bin/arm-linux-gcc'
>> cpp = '/home/thomas/projets/buildroot/output/per-package/toolchain/host/bin/arm-linux-g++'
>> ar = '/home/thomas/projets/buildroot/output/per-package/toolchain/host/bin/arm-linux-ar'
>> strip = '/home/thomas/projets/buildroot/output/per-package/toolchain/host/bin/arm-linux-strip'
>> pkgconfig = '/home/thomas/projets/buildroot/output/per-package/toolchain/host/usr/bin/pkg-config'
>>
>> So instead, we generate this file in TOOLCHAIN_TARGET_FINALIZE_HOOKS,
>> so that the global paths are used:
>>
>> [binaries]
>> c = '/home/thomas/projets/buildroot/output/host/bin/arm-linux-gcc'
>> cpp = '/home/thomas/projets/buildroot/output/host/bin/arm-linux-g++'
>> ar = '/home/thomas/projets/buildroot/output/host/bin/arm-linux-ar'
>> strip = '/home/thomas/projets/buildroot/output/host/bin/arm-linux-strip'
>> pkgconfig = '/home/thomas/projets/buildroot/output/host/usr/bin/pkg-config'
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> After giving it quite some thoughts, I think we do not want to provide
> any guarantee about the stableness of target/ vs. host/ on a partial
> rebuild, like Thomas P. said.
> As such, I have applied this patch now.
Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2020-09-15 19:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 15:02 [Buildroot] [PATCH] package/pkg-meson: ensure the global cross-compilation.conf file is correct Thomas Petazzoni
2019-12-04 16:49 ` Peter Seiderer
2019-12-05 22:13 ` Arnout Vandecappelle
2019-12-06 7:59 ` Thomas Petazzoni
2019-12-06 8:58 ` Arnout Vandecappelle
2019-12-06 9:00 ` Thomas Petazzoni
2019-12-06 9:54 ` Thomas De Schampheleire
2019-12-06 9:55 ` Thomas De Schampheleire
2019-12-06 9:57 ` Thomas Petazzoni
2019-12-06 10:16 ` Thomas De Schampheleire
2019-12-06 11:31 ` Arnout Vandecappelle
2019-12-06 20:53 ` Thomas De Schampheleire
2020-09-14 20:04 ` Yann E. MORIN
2020-09-15 19:03 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn6mrhg2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).