Re: [Buildroot] [PATCH next 2/3] package/inadyn: refactor start script

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Joachim" == Joachim Wiberg <troglobit@gmail.com> writes:

 > This patch is a complete rewrite of the Inadyn start script, based on
 > the BusyBox S01syslogd template.  Additional features, compared to the
 > template, are limited to the ability to:

 >  - Check if enabled, using an ENABLED="yes" from /etc/default/inadyn,
 >    this for compatibility with the previous version of the script
 >  - Override INADYN_ARGS from /etc/default/inadyn
 >  - A reload command that sends SIGHUP, since that works and is both
 >    quicker and a less resource intensive operation

 > Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
 > ---
 >  package/inadyn/S70inadyn | 100 +++++++++++++++++++++++++--------------
 >  1 file changed, 65 insertions(+), 35 deletions(-)
 >  mode change 100644 => 100755 package/inadyn/S70inadyn

 > diff --git a/package/inadyn/S70inadyn b/package/inadyn/S70inadyn
 > old mode 100644
 > new mode 100755
 > index ca7b414678..d44acacec3
 > --- a/package/inadyn/S70inadyn
 > +++ b/package/inadyn/S70inadyn
 > @@ -1,44 +1,74 @@
 >  #!/bin/sh
 > +# Customizations are sourced from /etc/default/inadyn.  For example,
 > +# override INADYN_ARGS to adjust log level, add a startup delay, etc.
 >  #
 > -# Start & stop the inadyn client
 > -#
 > +# NOTE: to start, add a line ENABLED="yes" to /etc/default/inadyn
 > +
 > +DAEMON="inadyn"
 > +PIDFILE="/var/run/$DAEMON.pid"
 > +
 > +INADYN_ARGS=""
 
 > -CONFIG=/etc/inadyn.conf
 > +# shellcheck source=/dev/null
 > +[ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON"
 
 > -# check if CONFIG exists, print message & exit if it doesn't
 > -[ ! -f $CONFIG ] && ( echo "The config file "$CONFIG" is missing...exiting now." && exit 2 )
 > +start()
 > +{

Our other init scripts have the { on the same line as the function, so
changed that and committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot