buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
From: James Hilliard <james.hilliard1@gmail.com>
To: Michael Nosthoff <buildroot@heine.tech>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Matt Weber <matthew.weber@collins.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/{python-}protobuf: bump to version 3.18.0
Date: Wed, 22 Sep 2021 02:04:53 -0600	[thread overview]
Message-ID: <CADvTj4r-qeq80rxX6OQY9+5JwoA1+nG5Cukym4E+1FHOvjuDfw@mail.gmail.com> (raw)
In-Reply-To: <24f90dee-41b4-5f42-99f6-4a9a35324143@heine.tech>

On Wed, Sep 22, 2021 at 1:56 AM Michael Nosthoff <buildroot@heine.tech> wrote:
>
> Hi,
>
> On 22.09.21 08:57, James Hilliard wrote:
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >   package/protobuf/protobuf.hash               | 2 +-
> >   package/protobuf/protobuf.mk                 | 2 +-
> >   package/python-protobuf/python-protobuf.hash | 2 +-
> >   3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/protobuf/protobuf.hash b/package/protobuf/protobuf.hash
> > index 2a65156cb3..777f19d6b9 100644
> > --- a/package/protobuf/protobuf.hash
> > +++ b/package/protobuf/protobuf.hash
> > @@ -1,3 +1,3 @@
> >   # Locally calculated
> >   sha256  6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d  LICENSE
> > -sha256  51cec99f108b83422b7af1170afd7aeb2dd77d2bcbb7b6bad1f92509e9ccf8cb  protobuf-cpp-3.17.3.tar.gz
> > +sha256  7308590dbb95e77066b99c5674eed855c8257e70658d2af586f4a81ff0eea2b1  protobuf-cpp-3.18.0.tar.gz
> > diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> > index fa8ea890e2..bb9c6bf37c 100644
> > --- a/package/protobuf/protobuf.mk
> > +++ b/package/protobuf/protobuf.mk
> > @@ -7,7 +7,7 @@
> >   # When bumping this package, make sure to also verify if the
> >   # python-protobuf package still works and to update its hash,
> >   # as they share the same version/site variables.
> > -PROTOBUF_VERSION = 3.17.3
> > +PROTOBUF_VERSION = 3.18.0
> >   PROTOBUF_SOURCE = protobuf-cpp-$(PROTOBUF_VERSION).tar.gz
> >   PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
> >   PROTOBUF_LICENSE = BSD-3-Clause
> > diff --git a/package/python-protobuf/python-protobuf.hash b/package/python-protobuf/python-protobuf.hash
> > index 8eca476884..e9a5ac4904 100644
> > --- a/package/python-protobuf/python-protobuf.hash
> > +++ b/package/python-protobuf/python-protobuf.hash
> > @@ -1,3 +1,3 @@
> >   # Locally calculated
> > -sha256  3253c6d17ec0bb6f6382e555cf5ca0a9ffab8d81b691f100f96ce9f5e753018e  protobuf-python-3.17.3.tar.gz
> > +sha256  4f792034070915819065c162a310142d66835333824e2e0a2ca26ed54b013408  protobuf-python-3.18.0.tar.gz
> >   sha256  6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d  LICENSE
>
>  From the Release Notes:
>
> Python
> * Drops support for 2.7 and 3.5.
>
> So I guess we should add a
> depends on BR2_PACKAGE_PYTHON3
> to package/python-protobuf/Config.in

Fixed in v2:
https://patchwork.ozlabs.org/project/buildroot/patch/20210922080347.150943-1-james.hilliard1@gmail.com/

>
>
> Regards,
> Michael
>
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-09-22  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  6:57 [Buildroot] [PATCH 1/1] package/{python-}protobuf: bump to version 3.18.0 James Hilliard
2021-09-22  7:56 ` Michael Nosthoff via buildroot
2021-09-22  8:04   ` James Hilliard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADvTj4r-qeq80rxX6OQY9+5JwoA1+nG5Cukym4E+1FHOvjuDfw@mail.gmail.com \
    --to=james.hilliard1@gmail.com \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=buildroot@heine.tech \
    --cc=matthew.weber@collins.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).