buildroot.busybox.net archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 4/7] package/rustc: fix the riscv64gc architecture handling
Date: Sat, 8 Jan 2022 10:23:15 +1000	[thread overview]
Message-ID: <CAKmqyKPKHCyDCS1K4jB66+Q8Wv=OZmsT3JCyS=OcV37JGQigCg@mail.gmail.com> (raw)
In-Reply-To: <20220107171318.1423075-5-thomas.petazzoni@bootlin.com>

On Sat, Jan 8, 2022 at 3:14 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> riscv64gc was made available for BR2_riscv, but RISC-V can be 32-bit
> or 64-bit, so we need to restrict it to BR2_RISCV_64. There's no need
> to keep the BR2_riscv dependency, as BR2_RISCV_64 can only be true
> when BR2_riscv is true.
>
> Also, BR2_PACKAGE_HOST_RUSTC_ARCH needs to be set to riscv64gc to
> allow rust-bin to download its pre-compiled standard library
> correctly.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  package/rustc/Config.in.host | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/rustc/Config.in.host b/package/rustc/Config.in.host
> index 05324ad755..8c8b75c0a2 100644
> --- a/package/rustc/Config.in.host
> +++ b/package/rustc/Config.in.host
> @@ -49,7 +49,7 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_HOST_TOOLS_PLATFORMS
>         default y if BR2_powerpc64le && BR2_TOOLCHAIN_USES_GLIBC
>         # riscv64gc-unknown-linux-gnu
>         # "g" stands for imafd, and we also need "c".
> -       default y if BR2_riscv && BR2_RISCV_ISA_RVI && BR2_RISCV_ISA_RVM && \
> +       default y if BR2_RISCV_64 && BR2_RISCV_ISA_RVI && BR2_RISCV_ISA_RVM && \
>                         BR2_RISCV_ISA_RVA && BR2_RISCV_ISA_RVF && \
>                         BR2_RISCV_ISA_RVD && BR2_RISCV_ISA_RVC && \
>                         BR2_TOOLCHAIN_USES_GLIBC
> @@ -104,6 +104,7 @@ config BR2_PACKAGE_HOST_RUSTC_ARCH
>         string
>         default "armv5te" if BR2_ARM_CPU_ARMV5
>         default "armv7"  if BR2_ARM_CPU_ARMV7A
> +       default "riscv64gc" if BR2_RISCV_64
>         default BR2_ARCH if !BR2_ARM_CPU_ARMV7A
>
>  config BR2_PACKAGE_HOST_RUSTC_ABI
> --
> 2.33.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-01-08  0:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 17:13 [Buildroot] [PATCH 0/7] Bump of python-cryptography and other Rust related fun Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 1/7] package/ca-certificates: remove dependency on host-python-cryptography Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 2/7] package/python-cryptography: drop host variant Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 3/7] package/rustc: fix BR2_PACKAGE_HOST_RUSTC_ARCH for ARMv5 Thomas Petazzoni
2022-01-07 17:57   ` Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 4/7] package/rustc: fix the riscv64gc architecture handling Thomas Petazzoni
2022-01-08  0:23   ` Alistair Francis [this message]
2022-01-07 17:13 ` [Buildroot] [PATCH 5/7] support/download/cargo-post-process: make manifest path configurable Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 6/7] support/testing/tests: switch python-cryptography related tests to glibc Thomas Petazzoni
2022-01-07 17:13 ` [Buildroot] [PATCH 7/7] DO-NOT-APPLY package/python-cryptography: bump version to 36.0.1 Thomas Petazzoni
2022-01-08 16:52 ` [Buildroot] [PATCH 0/7] Bump of python-cryptography and other Rust related fun Arnout Vandecappelle
2022-01-09 11:16 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKPKHCyDCS1K4jB66+Q8Wv=OZmsT3JCyS=OcV37JGQigCg@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).