From: Max Filippov <jcmvbkbc@gmail.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] arch/xtensa: xtensa little endian target requires an overlay file
Date: Wed, 7 Sep 2022 15:59:50 -0700 [thread overview]
Message-ID: <CAMo8BfKHKuVC86uOwP0z8CzE425q7u0B_q6jdeU0Rw9upaiY=Q@mail.gmail.com> (raw)
In-Reply-To: <20220906155656.GG1585594@scaer>
On Tue, Sep 6, 2022 at 8:57 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> On 2022-09-04 22:04 +0200, Romain Naour spake thusly:
> > Using a custom Xtensa processor configuration select little endian
> > by default. But xtensa for little endian requires an xtensa overlay
> > file containing a version of xtensa-config.h header for gcc setting
> > XCHAL_HAVE_BE to 0.
> >
> > When BR2_XTENSA_LITTLE_ENDIAN is selected, we have to check if
> > an overlay file is provided. Error out if BR2_XTENSA_OVERLAY_FILE
> > is empty.
>
> Well, why don't we always check for an overlay when BR2_XTENSA_CUSTOM=y?
>
> Indeed, whether big or little endian, if the user selects a custom
> xtensa configuration, they better provide the overlay for that
> configuration, otherwise that does not make sense, and they should be
> using BR2_xtensa_fsf=y instead.
This sounds perfectly reasonable to me.
--
Thanks.
-- Max
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-07 23:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 20:04 [Buildroot] [PATCH] arch/xtensa: xtensa little endian target requires an overlay file Romain Naour
2022-09-06 15:56 ` Yann E. MORIN
2022-09-06 16:54 ` Romain Naour
2022-09-07 22:59 ` Max Filippov [this message]
2022-09-08 9:46 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMo8BfKHKuVC86uOwP0z8CzE425q7u0B_q6jdeU0Rw9upaiY=Q@mail.gmail.com' \
--to=jcmvbkbc@gmail.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).