Re: [Buildroot] [PATCH 5/5] package/cog: bump to version 0.16.0

From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Adrian Perez de Castro <aperez@igalia.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 5/5] package/cog: bump to version 0.16.0
Date: Thu, 6 Oct 2022 09:13:01 +0200	[thread overview]
Message-ID: <Yz5//dAdsZQYniP9@p1g2> (raw)
In-Reply-To: <20221004133057.2003750-6-aperez@igalia.com>

Hi Adrian,

On Tue, Oct 04, 2022 at 04:30:57PM +0300, Adrian Perez de Castro wrote:
> This new version includes support for setting proxy options and gamepad
> support. Release notes:
> 
>   https://wpewebkit.org/release/cog-0.16.0.html
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
> ---
>  package/cog/cog.hash |  8 ++++----
>  package/cog/cog.mk   | 37 ++++++++++++++++++++-----------------
>  2 files changed, 24 insertions(+), 21 deletions(-)
> 
> diff --git a/package/cog/cog.hash b/package/cog/cog.hash
> index aa128d73d8..a2c55c4b94 100644
> --- a/package/cog/cog.hash
> +++ b/package/cog/cog.hash
> @@ -1,7 +1,7 @@
> -# From https://wpewebkit.org/releases/cog-0.14.1.tar.xz.sums
> -md5  69d72ac046a0fc485ea7b61b96e7e7fc  cog-0.14.1.tar.xz
> -sha1  6236972b0ae0bce38a0a017610f161b349723862  cog-0.14.1.tar.xz
> -sha256  fb91104e25e1dde27189c91c70acc356e387f47acebaa8997e01ce5879c3a600  cog-0.14.1.tar.xz
> +# From https://wpewebkit.org/releases/cog-0.16.0.tar.xz.sums
> +md5  2705472ea4f333290973722c0862b21d  cog-0.16.0.tar.xz
> +sha1  ef16e5e3d91d0da056fe5e4f596c211af7453b4e  cog-0.16.0.tar.xz
> +sha256  2956f719d36c9a6368f63901a0d1ceaf4d27f529f7df441b3748c36d72906fc6  cog-0.16.0.tar.xz
>  
>  # Hashes for license files:
>  sha256  e6c42d93c68b292bcccf6d2ec3e13da85df90b718ba27c2c2a01053a9d009252  COPYING
> diff --git a/package/cog/cog.mk b/package/cog/cog.mk
> index 1f24bebee4..ac2ec2a30e 100644
> --- a/package/cog/cog.mk
> +++ b/package/cog/cog.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -COG_VERSION = 0.14.1
> +COG_VERSION = 0.16.0
>  COG_SITE = https://wpewebkit.org/releases
>  COG_SOURCE = cog-$(COG_VERSION).tar.xz
>  COG_INSTALL_STAGING = YES
> @@ -12,37 +12,40 @@ COG_DEPENDENCIES = dbus wpewebkit wpebackend-fdo wayland
>  COG_LICENSE = MIT
>  COG_LICENSE_FILES = COPYING
>  COG_CONF_OPTS = \
> -	-DCOG_BUILD_PROGRAMS=ON \
> -	-DCOG_PLATFORM_HEADLESS=ON \
> -	-DINSTALL_MAN_PAGES=OFF \
> -	-DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))' \
> -	-DUSE_SOUP2=ON
> +	-Ddocumentation=false \
> +	-Dmanpages=false \
> +	-Dprograms=true \
> +	-Dsoup2=true \

I'm testing your series and it seems like the above is not correct, it
should be '-Dsoup2=enabled' as soup2 isn't a boolean option. Currently
it is throwing the following error:
../output/build/cog-0.16.0/meson.build:1:0: ERROR: Value "true" (of type "string") for combo option "Build with libsoup2 instead of libsoup3" is not one of the choices. Possible choices are (as string): "enabled", "disabled", "auto".

By using enabled I got another failure due to the wayland platform not
finding drm_fourcc.h, I submitted a patch to Cog directly[1].

Regards,
Gary

[1] https://github.com/Igalia/cog/pull/501
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot