Re: [Buildroot] [PATCH 1/2] package/minizip: add minizip-zlib support

[Arnout Vandecappelle <arnout@mind.be>]

  Hi Fabrice,

On 08/01/2022 23:43, Fabrice Fontaine wrote:
> Add a virtual package to allow the user to select the minizip provider:

  A virtual package should be used when the alternatives are more or less 
drop-in replacements. Here, however, they are absolutely not: they install 
completely different header files and libraries. There is no way that something 
that expects minizip-ng can build with minizip-zlib or vice versa.

  In addition, the two can be installed in parallel.

  So there's no reason at all to make it a virtual package.

>   - the current minizip (which has been renamed minizip-ng since
>     https://github.com/zlib-ng/minizip-ng/commit/db95894646b87f6178ceaa389cbdb5b1ba8cd97a)

  It would make more sense to switch the existing minizip package to this new 
upstream repository.

  We could rename the package to minizip-ng, but we generally avoid that. It's 
just annoyance for people who upgrade buildroot (legacy handling helps, but it 
is still annoying), and there is no benefit at all other than "consistency".

>   - the 'legacy' minizip provided by zlib which is still widely supported
>     by various opensource packages such as domoticz

  We should just add a package minizip-zlib.


> There is no need to add entries in Config.legacy as the previous options
> are kept and the default provider of minizip is minizip-ng.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

[snip]
> diff --git a/package/minizip-zlib/minizip-zlib.mk b/package/minizip-zlib/minizip-zlib.mk
> new file mode 100644
> index 0000000000..67d4e31f41
> --- /dev/null
> +++ b/package/minizip-zlib/minizip-zlib.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# minizip-zlib
> +#
> +################################################################################
> +
> +MINIZIP_ZLIB_VERSION = 1.2.11
> +MINIZIP_ZLIB_SOURCE = zlib-$(MINIZIP_ZLIB_VERSION).tar.xz
> +MINIZIP_ZLIB_SITE = http://www.zlib.net
> +MINIZIP_ZLIB_LICENSE = Zlib
> +MINIZIP_ZLIB_LICENSE_FILES = README
> +MINIZIP_ZLIB_INSTALL_STAGING = YES
> +MINIZIP_ZLIB_PROVIDES = minizip
> +MINIZIP_ZLIB_SUBDIR = contrib/minizip
> +MINIZIP_ZLIB_AUTORECONF = YES

  Please add a comment why autoreconf is needed.

  Regards,
  Arnout

> +MINIZIP_ZLIB_DEPENDENCIES = zlib
> +
> +ifeq ($(BR2_PACKAGE_MINIZIP_DEMOS),y)
> +MINIZIP_ZLIB_CONF_OPTS += --enable-demos
> +else
> +MINIZIP_ZLIB_CONF_OPTS += --disable-demos
> +endif
> +
> +$(eval $(autotools-package))
[snip]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot