c-std-porting.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: Neal Gompa <ngompa13@gmail.com>
Cc: Jan Engelhardt <jengelh@inai.de>,
	Florian Weimer <fweimer@redhat.com>,
	oS-fctry <factory@lists.opensuse.org>,
	c-std-porting@lists.linux.dev
Subject: Re: More C errors by default in GCC 14 (implicit function declarations etc.)
Date: Tue, 18 Apr 2023 15:37:41 +0100	[thread overview]
Message-ID: <87bkjl8d7l.fsf@gentoo.org> (raw)
In-Reply-To: <CAEg-Je-d-jHuOC_jQG=fNiUV6CmLiV283J2Vto4ECa-D2QQ2qQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]


Neal Gompa <ngompa13@gmail.com> writes:

> On Tue, Apr 18, 2023 at 9:42 AM Jan Engelhardt <jengelh@inai.de> wrote:
>>
>>
>> On Tuesday 2023-04-18 15:19, Neal Gompa wrote:
>> >On Tue, Apr 18, 2023 at 8:36 AM Florian Weimer <fweimer@redhat.com> wrote:
>> >>
>> >> TL;DR: I want to propose a GCC 14 change which will impact
>> >> distributions, so I'd like to gather some feedback from OpenSUSE.
>> >>
>> >> Specifically, I'm investigating the following changes:
>> >>
>> >> * -Werror=implicit-function-declaration
>> >> * -Werror=implict-int
>> >> * (tentative) -Werror=int-conversion
>> >> * (very tentative) -Werror=incompatible-pointer-types
>> >> * For -Wdiscarded-qualifies
>> >>
>> >> I want to propose at least the first two for GCC 14.
>>
>> Might as well enable all of it at once, then the community only needs
>> one pass per defective software.
>>
>
> I would also like to reiterate this point. The worst thing you can do
> is slow-roll changes like this. Being punched in the face once is
> better than being punched in the face several times in succession.
> Having to deal with this in Fedora, I would really rather not do it
> over and over and over if we can do it all at once.
>
> (Yes, I really feel like dealing with these changes is equivalent to
> getting punched in the face. I dealt with them far too much with my
> C++ packages in Fedora.)

Yeah, I can understand that point, and I'd like to do more, *but* that's
likely to only be feasible if we have at least one person from openSUSE
(ideally more!) championing it and doing tests with some of the flags
(Florian and I can share our setups - they're quite different to each
other, etc if needed).

It (broadly) consists of doing a full rebuild with some strict flags
and deciding on a method of obtaining the errors and capturing them
(might use a compiler wrapper, might use a patched GCC like Fedora is,
might try to grep logs in the build dir afterwards, etc).

If we had someone else helping out with this with some of these
additional warnings, it becomes more realistic for us to try target it.

In Gentoo, we're already partly doing this because Clang 16 made most
of these changes already, but I'm prioritising the bugs with warnings
that I know GCC is likely to make fatal soon too.

From what I've seen, -Wint-conversion and -Wincompatible-pointer-types
are much rarer, but they also sometimes require more analysis to fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]

  reply	other threads:[~2023-04-18 14:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 12:36 More C errors by default in GCC 14 (implicit function declarations etc.) Florian Weimer
2023-04-18 13:19 ` Neal Gompa
2023-04-18 13:42   ` Jan Engelhardt
2023-04-18 13:55     ` Neal Gompa
2023-04-18 14:37       ` Sam James [this message]
2023-04-26 13:16         ` Neal Gompa
2023-04-20 13:42   ` Bernhard Voelker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkjl8d7l.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=c-std-porting@lists.linux.dev \
    --cc=factory@lists.opensuse.org \
    --cc=fweimer@redhat.com \
    --cc=jengelh@inai.de \
    --cc=ngompa13@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).