c-std-porting.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Neal Gompa <ngompa13@gmail.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Florian Weimer <fweimer@redhat.com>,
	oS-fctry <factory@lists.opensuse.org>,
Subject: Re: More C errors by default in GCC 14 (implicit function declarations etc.)
Date: Tue, 18 Apr 2023 09:55:27 -0400	[thread overview]
Message-ID: <CAEg-Je-d-jHuOC_jQG=fNiUV6CmLiV283J2Vto4ECa-D2QQ2qQ@mail.gmail.com> (raw)
In-Reply-To: <5sp660qo-n6s4-r56-s73-ps1292s9rpss@vanv.qr>

On Tue, Apr 18, 2023 at 9:42 AM Jan Engelhardt <jengelh@inai.de> wrote:
> On Tuesday 2023-04-18 15:19, Neal Gompa wrote:
> >On Tue, Apr 18, 2023 at 8:36 AM Florian Weimer <fweimer@redhat.com> wrote:
> >>
> >> TL;DR: I want to propose a GCC 14 change which will impact
> >> distributions, so I'd like to gather some feedback from OpenSUSE.
> >>
> >> Specifically, I'm investigating the following changes:
> >>
> >> * -Werror=implicit-function-declaration
> >> * -Werror=implict-int
> >> * (tentative) -Werror=int-conversion
> >> * (very tentative) -Werror=incompatible-pointer-types
> >> * For -Wdiscarded-qualifies
> >>
> >> I want to propose at least the first two for GCC 14.
> Might as well enable all of it at once, then the community only needs
> one pass per defective software.

I would also like to reiterate this point. The worst thing you can do
is slow-roll changes like this. Being punched in the face once is
better than being punched in the face several times in succession.
Having to deal with this in Fedora, I would really rather not do it
over and over and over if we can do it all at once.

(Yes, I really feel like dealing with these changes is equivalent to
getting punched in the face. I dealt with them far too much with my
C++ packages in Fedora.)

> >> The numbers so far don't look great, but are manageable.  Fedora has
> >> 23,101 source package last time a looked.  We have fixed 796 of them,
> 3.8% is actually really great for syntax-related changes,
> reproducible-builds (in openSUSE) also has a nay ratio of ~3.4%,
> but of course r-b is more difficult to fix I think.

Build reproducibility (as defined by Debian, which is what openSUSE
follows) also has disputed usefulness among the broader community,
especially upstreams. That makes it harder for things to be fixed in
the first place.

> >> I would appreciate some discussion on the OpenSUSE impact.  I assume
> >> OpenSUSE does mass rebuilds after GCC rebases, a bit like Fedora?
> >
> >openSUSE does rebuilds of the whole distribution on a fairly regular
> >basis
> There is a also staging project (ironically named
> openSUSE:Factory:Staging:Gcc7) where a new gcc (not 7) gets to
> test-build a sizable portion of the distro before promoting it in
> openSUSE:Factory and before causing the super rebuild.

Super rebuilds are fun though. :)

真実はいつも一つ!/ Always, there's only one truth!

  reply	other threads:[~2023-04-18 13:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 12:36 More C errors by default in GCC 14 (implicit function declarations etc.) Florian Weimer
2023-04-18 13:19 ` Neal Gompa
2023-04-18 13:42   ` Jan Engelhardt
2023-04-18 13:55     ` Neal Gompa [this message]
2023-04-18 14:37       ` Sam James
2023-04-26 13:16         ` Neal Gompa
2023-04-20 13:42   ` Bernhard Voelker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEg-Je-d-jHuOC_jQG=fNiUV6CmLiV283J2Vto4ECa-D2QQ2qQ@mail.gmail.com' \
    --to=ngompa13@gmail.com \
    --cc=c-std-porting@lists.linux.dev \
    --cc=factory@lists.opensuse.org \
    --cc=fweimer@redhat.com \
    --cc=jengelh@inai.de \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).