Re: [PATCH 0/9] spi: axi-spi-engine: improvements round 2

From: "Nuno Sá" <noname.nuno@gmail.com>
To: David Lechner <dlechner@baylibre.com>, linux-spi@vger.kernel.org
Cc: "Mark Brown" <broonie@kernel.org>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	linux-kernel@vger.kernel.org,
	"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH 0/9] spi: axi-spi-engine: improvements round 2
Date: Tue, 05 Dec 2023 16:12:03 +0100	[thread overview]
Message-ID: <c029f2e5d49d8640fed59639224296e3479682aa.camel@gmail.com> (raw)
In-Reply-To: <20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com>

On Mon, 2023-12-04 at 11:33 -0600, David Lechner wrote:
> We are working towards adding support for the offload feature [1] of the
> AXI SPI Engine IP core. Before we can do that, we want to make some
> general fixes and improvements to the driver. In order to avoid a giant
> series with 35+ patches, we are splitting this up into a few smaller
> series.
> 
> This is a continuation of the work started in [2] which has been applied
> to spi/for-6.8 [3]. This series must be applied on top of that series to
> apply cleanly.
> 
> Once this series is applied, we will follow up with the 3rd series that
> implements the offload support. The offload support will also involve
> the IIO subsystem (a new IIO driver will depend on the new SPI offload
> feature), so I'm mentioning this now in case we want to do anything
> ahead of time to prepare for that (e.g. putting all of these changes on
> a separate branch).
> 
> [1]: https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload
> [2]:
> https://lore.kernel.org/linux-spi/20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com/
> [3]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/log/?h=for-6.8
> 
> ---

Acked-by: Nuno Sa <nuno.sa@analog.com>

> David Lechner (9):
>       spi: axi-spi-engine: return void from spi_engine_compile_message()
>       spi: axi-spi-engine: populate xfer->effective_speed_hz
>       spi: axi-spi-engine: remove spi_engine_get_clk_div()
>       spi: axi-spi-engine: fix sleep ticks calculation
>       spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep()
>       spi: axi-spi-engine: implement xfer->cs_change_delay
>       spi: axi-spi-engine: restore clkdiv at end of message
>       spi: axi-spi-engine: remove delay from CS assertion
>       spi: axi-spi-engine: add watchdog timer
> 
>  drivers/spi/spi-axi-spi-engine.c | 116 ++++++++++++++++++++++++++-------------
>  1 file changed, 77 insertions(+), 39 deletions(-)
> ---
> base-commit: 8e6a43961f24cf841d3c0d199521d0b284d948b9
> change-id: 20231129-axi-spi-engine-series-2-5f0a6053dea0