From: Jan Beulich <jbeulich@suse.com>
To: Kevin Stefanov <kevin.stefanov@citrix.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Kevin Tian" <kevin.tian@intel.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/2] x86/ioapic: Remove use of TRUE/FALSE/1/0
Date: Wed, 11 Aug 2021 14:41:42 +0200 [thread overview]
Message-ID: <c070b7e2-8cc1-0168-4369-5f294c446fbe@suse.com> (raw)
In-Reply-To: <20210811123135.18195-3-kevin.stefanov@citrix.com>
On 11.08.2021 14:31, Kevin Stefanov wrote:
> @@ -448,7 +448,7 @@ void io_apic_write_remap_rte(
> struct vtd_iommu *iommu = ioapic_to_iommu(IO_APIC_ID(apic));
> int saved_mask;
>
> - old_rte = __ioapic_read_entry(apic, ioapic_pin, 1);
> + old_rte = __ioapic_read_entry(apic, ioapic_pin, false);
Oops? I'm relatively certain that things wouldn't work this way,
i.e. I'm wondering if you did actually test before submitting.
Jan
prev parent reply other threads:[~2021-08-11 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 12:31 [PATCH v2 0/2] xen: Replace uses of TRUE/FALSE Kevin Stefanov
2021-08-11 12:31 ` [PATCH v2 1/2] xen/kexec: Remove use " Kevin Stefanov
2021-08-11 12:31 ` [PATCH v2 2/2] x86/ioapic: Remove use of TRUE/FALSE/1/0 Kevin Stefanov
2021-08-11 12:41 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c070b7e2-8cc1-0168-4369-5f294c446fbe@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=kevin.stefanov@citrix.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.