Re: [PATCH v2 0/5] ASoC: sh: rz-ssi: Code cleanup and fixes

From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Pavel Machek <pavel@denx.de>, <linux-renesas-soc@vger.kernel.org>,
	Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH v2 0/5] ASoC: sh: rz-ssi: Code cleanup and fixes
Date: Wed, 19 Jan 2022 15:11:53 +0100	[thread overview]
Message-ID: <c085fb37-23b6-ceb8-422e-7143209ede6d@intel.com> (raw)
In-Reply-To: <20220115012303.29651-1-prabhakar.mahadev-lad.rj@bp.renesas.com>

On 2022-01-15 2:22 AM, Lad Prabhakar wrote:
> Hi All,
> 
> This patch series does code cleanup and fixes to the rz-ssi driver.

Hello,

Suggestion for the future contributions below. My input is *not* to be 
treated as a blocker for the series and is not a reason for re-sending it.

Cover letter should provide a high-level view of the series. That 
includes but is not limited to the overall layout of the series. Here, 
it would be good to state why the fixes are made. Also, it is preferred 
to have the fixes leading the series, _before_ any cleanups.

This summary suggests that cleanups are leading the series instead. 
Think of cover-letter as of news-paper. Subsystem maintainers such as 
Mark and Takashi start here (read the first page first) to get the 
general idea of what the contributor is sending them. Being transparent 
only helps. Good descriptions also helps reviewers to know which patches 
to look at first. Fixes are obviously of more importance as they usually 
address issues troubling users of the release-builds. Such patches are 
also often backported down the stream, increasing the importance for 
their review.

There's more to it, but for the scope of this cover letter, this should 
suffice. It's just a suggestion but I hope you find it useful.

Regards,
Czarek

> Cheers,
> Prabhakar
> 
> Lad Prabhakar (5):
>    ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively
>    ASoC: sh: rz-ssi: Make the data structures available before
>      registering the handlers
>    ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init()
>    ASoC: sh: rz-ssi: Change return type of rz_ssi_stream_is_valid() to
>      bool
>    ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function
> 
>   sound/soc/sh/rz-ssi.c | 107 +++++++++++++++++++++---------------------
>   1 file changed, 54 insertions(+), 53 deletions(-)
> 