From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Shuah Khan <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"H . Peter Anvin" <hpa@zytor.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Tony Luck <tony.luck@intel.com>, Kai Huang <kai.huang@intel.com>,
Wander Lairson Costa <wander@redhat.com>,
Isaku Yamahata <isaku.yamahata@gmail.com>,
marcelo.cerri@canonical.com, tim.gardner@canonical.com,
khalid.elmously@canonical.com, philip.cox@canonical.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v15 2/3] virt: Add TDX guest driver
Date: Sun, 23 Oct 2022 09:13:11 -0700 [thread overview]
Message-ID: <c09184e3-ac15-b230-6dea-d6718f6f0ab0@linux.intel.com> (raw)
In-Reply-To: <Y1Iimg0WItgIGq6/@kroah.com>
On 10/20/22 9:39 PM, Greg Kroah-Hartman wrote:
>>> You are allowing userspace to spam the kernel logs, please do not do
>>> that.
>> Added it to help userspace understand the reason for the failure (only for
>> the cases like request param issues and TDCALL failure). Boris recommended
>> adding it in the previous review.
> Again, you just created a vector for userspace to spam the kernel log.
> No kernel driver should ever do that.
>
Brois, any comments? Do you also agree?
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2022-10-23 16:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 4:58 [PATCH v15 0/3]] Add TDX Guest Attestation support Kuppuswamy Sathyanarayanan
2022-10-20 4:58 ` [PATCH v15 1/3] x86/tdx: Add a wrapper to get TDREPORT from the TDX Module Kuppuswamy Sathyanarayanan
2022-10-20 4:58 ` [PATCH v15 2/3] virt: Add TDX guest driver Kuppuswamy Sathyanarayanan
2022-10-20 5:38 ` Greg Kroah-Hartman
2022-10-21 0:00 ` Sathyanarayanan Kuppuswamy
2022-10-21 4:39 ` Greg Kroah-Hartman
2022-10-21 23:51 ` Sathyanarayanan Kuppuswamy
2022-10-22 6:05 ` Greg Kroah-Hartman
2022-10-22 6:42 ` Sathyanarayanan Kuppuswamy
2022-10-23 16:13 ` Sathyanarayanan Kuppuswamy [this message]
2022-10-24 12:57 ` Wander Lairson Costa
2022-10-24 13:54 ` Greg Kroah-Hartman
2022-10-24 23:59 ` Sathyanarayanan Kuppuswamy
2022-10-24 14:17 ` Dave Hansen
2022-10-25 0:20 ` Sathyanarayanan Kuppuswamy
2022-10-20 4:58 ` [PATCH v15 3/3] selftests: tdx: Test TDX attestation GetReport support Kuppuswamy Sathyanarayanan
2022-10-20 17:08 ` [PATCH v15 0/3]] Add TDX Guest Attestation support Dave Hansen
2022-10-23 16:09 ` Sathyanarayanan Kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c09184e3-ac15-b230-6dea-d6718f6f0ab0@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@gmail.com \
--cc=kai.huang@intel.com \
--cc=khalid.elmously@canonical.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mingo@redhat.com \
--cc=philip.cox@canonical.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.