From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Ricardo Ribalda <ribalda@chromium.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 4/9] media: fdp1: Do not zero reserved fields
Date: Tue, 12 Jan 2021 10:58:38 +0000 [thread overview]
Message-ID: <c0f4e1ad-ffb9-5d0c-dfed-4c0772b2097b@ideasonboard.com> (raw)
In-Reply-To: <20210111145445.28854-5-ribalda@chromium.org>
Hi Ricardo,
On 11/01/2021 14:54, Ricardo Ribalda wrote:
> Core code already clears reserved fields of struct
> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> v4l2_plane_pix_format reserved fields").
>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
I love a good cleanup series.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/rcar_fdp1.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_fdp1.c b/drivers/media/platform/rcar_fdp1.c
> index c9448de885b6..01c1fbb97bf6 100644
> --- a/drivers/media/platform/rcar_fdp1.c
> +++ b/drivers/media/platform/rcar_fdp1.c
> @@ -1439,8 +1439,6 @@ static void fdp1_compute_stride(struct v4l2_pix_format_mplane *pix,
> pix->plane_fmt[i].sizeimage = pix->plane_fmt[i].bytesperline
> * pix->height / vsub;
>
> - memset(pix->plane_fmt[i].reserved, 0,
> - sizeof(pix->plane_fmt[i].reserved));
> }
>
> if (fmt->num_planes == 3) {
> @@ -1448,8 +1446,6 @@ static void fdp1_compute_stride(struct v4l2_pix_format_mplane *pix,
> pix->plane_fmt[2].bytesperline = pix->plane_fmt[1].bytesperline;
> pix->plane_fmt[2].sizeimage = pix->plane_fmt[1].sizeimage;
>
> - memset(pix->plane_fmt[2].reserved, 0,
> - sizeof(pix->plane_fmt[2].reserved));
> }
> }
>
>
next prev parent reply other threads:[~2021-01-12 10:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 14:54 [PATCH 1/9] media: ipu3-cio2: Do not zero reserved fields Ricardo Ribalda
2021-01-11 14:54 ` [PATCH] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:59 ` Kieran Bingham
2021-01-12 12:14 ` Ricardo Ribalda
2021-01-11 14:54 ` [PATCH 2/9] media: mtk-mdp: " Ricardo Ribalda
2021-01-12 12:01 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 3/9] media: mtk-vcodec: " Ricardo Ribalda
2021-01-12 12:09 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 4/9] media: fdp1: " Ricardo Ribalda
2021-01-12 10:58 ` Kieran Bingham [this message]
2021-01-11 14:54 ` [PATCH 5/9] media: jpu: " Ricardo Ribalda
2021-01-12 11:07 ` Kieran Bingham
2021-01-21 9:53 ` Hans Verkuil
2021-01-11 14:54 ` [PATCH 6/9] media: sum4i-csi: " Ricardo Ribalda
2021-01-11 18:11 ` Ezequiel Garcia
2021-01-12 11:10 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 7/9] media: ti-vpe: " Ricardo Ribalda
2021-01-12 11:12 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 8/9] media: vicodec: " Ricardo Ribalda
2021-01-12 11:44 ` Kieran Bingham
2021-01-11 14:54 ` [PATCH 9/9] media: staging/intel-ipu3 : " Ricardo Ribalda
2021-01-12 11:55 ` Kieran Bingham
2021-01-12 11:58 ` [PATCH 1/9] media: ipu3-cio2: " Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f4e1ad-ffb9-5d0c-dfed-4c0772b2097b@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.