From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Demi Marie Obenour <demi@invisiblethingslab.com>
Cc: Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [v2 2/4] dm ioctl: Allow userspace to provide expected diskseq
Date: Mon, 26 Jun 2023 15:30:45 +0200 [thread overview]
Message-ID: <c1b84520-94d2-2c5c-6eed-2a0697c086a4@web.de> (raw)
In-Reply-To: <e42e8115-6f75-447e-9955-ca4ad43ed406@kadam.mountain>
> Markus, stop bothering people about trivial nonsense.
I suggest to reconsider such feedback a bit more.
I got the impression that an information like “Describe your changes in imperative mood”
belongs to a basic requirement.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94
You shared your special opinions for this topic also at other places recently,
didn't you?
> I've said this to you before, that if you spot a bug in a patch
I got trained to take also another look at various change descriptions.
> that's welcome feedback
Further details can occasionally be improved by the means of patch reviews.
> but if you just have comments about grammar then no one wants that.
I know that some contributors and maintainers would like to care for nicer wordings.
Regards,
Markus
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2023-07-10 6:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 23:09 [PATCH v2 0/4] Diskseq support in device-mapper Demi Marie Obenour
2023-06-24 23:09 ` [dm-devel] " Demi Marie Obenour
2023-06-24 23:09 ` [PATCH v2 1/4] dm ioctl: Allow userspace to opt-in to strict parameter checks Demi Marie Obenour
2023-06-24 23:09 ` [dm-devel] " Demi Marie Obenour
2023-06-24 23:09 ` [PATCH v2 2/4] dm ioctl: Allow userspace to provide expected diskseq Demi Marie Obenour
2023-06-24 23:09 ` [dm-devel] " Demi Marie Obenour
2023-06-25 11:23 ` Markus Elfring
2023-06-25 17:39 ` Demi Marie Obenour
2023-06-25 17:39 ` [dm-devel] " Demi Marie Obenour
2023-06-26 12:59 ` Dan Carpenter
2023-06-26 12:59 ` [dm-devel] " Dan Carpenter
2023-06-26 13:30 ` Markus Elfring [this message]
2023-06-26 14:51 ` [v2 " Dan Carpenter
2023-06-26 14:51 ` [dm-devel] " Dan Carpenter
2023-06-26 15:19 ` Markus Elfring
2023-06-26 16:20 ` [dm-devel] [PATCH v2 " Markus Elfring
2023-06-27 6:14 ` Dan Carpenter
2023-06-27 6:14 ` [dm-devel] " Dan Carpenter
2023-06-27 7:19 ` [dm-devel] [v2 " Markus Elfring
2023-06-24 23:09 ` [PATCH v2 3/4] dm ioctl: Allow userspace to suppress uevent generation Demi Marie Obenour
2023-06-24 23:09 ` [dm-devel] " Demi Marie Obenour
2023-06-25 13:25 ` Milan Broz
2023-06-25 13:25 ` Milan Broz
2023-06-25 16:02 ` Demi Marie Obenour
2023-06-25 16:02 ` Demi Marie Obenour
2023-06-25 16:33 ` Milan Broz
2023-06-25 16:33 ` Milan Broz
2023-06-25 16:43 ` Demi Marie Obenour
2023-06-25 16:43 ` Demi Marie Obenour
2023-06-25 17:13 ` Milan Broz
2023-06-25 17:13 ` Milan Broz
2023-06-24 23:09 ` [PATCH v2 4/4] dm ioctl: inform caller about already-existing device Demi Marie Obenour
2023-06-24 23:09 ` [dm-devel] " Demi Marie Obenour
2024-01-15 17:56 ` [dm-devel] [PATCH v2 0/4] Diskseq support in device-mapper Martin Wilck
2024-01-15 21:44 ` Demi Marie Obenour
2024-01-16 8:00 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1b84520-94d2-2c5c-6eed-2a0697c086a4@web.de \
--to=markus.elfring@web.de \
--cc=agk@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=demi@invisiblethingslab.com \
--cc=dm-devel@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.