Re: [PATCH v3 0/5] backup: discard-source parameter

From: Fiona Ebner <f.ebner@proxmox.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
	qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com,
	xiechanglong.d@gmail.com, wencongyang2@huawei.com,
	hreitz@redhat.com, kwolf@redhat.com, jsnow@redhat.com,
	den@virtuozzo.com, alexander.ivanov@virtuozzo.com
Subject: Re: [PATCH v3 0/5] backup: discard-source parameter
Date: Fri, 8 Mar 2024 16:49:59 +0100	[thread overview]
Message-ID: <c2251dd3-0e7e-4f97-86a1-cb01f98a2bb2@proxmox.com> (raw)
In-Reply-To: <20240228141501.455989-1-vsementsov@yandex-team.ru>

Am 28.02.24 um 15:14 schrieb Vladimir Sementsov-Ogievskiy:
> Hi all! The main patch is 04, please look at it for description and
> diagram.
> 
> v3:
> 02: new patch
> 04: take WRITE permission only when discard_source is required
> 
> Vladimir Sementsov-Ogievskiy (5):
>   block/copy-before-write: fix permission
>   block/copy-before-write: support unligned snapshot-discard
>   block/copy-before-write: create block_copy bitmap in filter node
>   qapi: blockdev-backup: add discard-source parameter
>   iotests: add backup-discard-source
> 
>  block/backup.c                                |   5 +-
>  block/block-copy.c                            |  12 +-
>  block/copy-before-write.c                     |  39 ++++-
>  block/copy-before-write.h                     |   1 +
>  block/replication.c                           |   4 +-
>  blockdev.c                                    |   2 +-
>  include/block/block-common.h                  |   2 +
>  include/block/block-copy.h                    |   2 +
>  include/block/block_int-global-state.h        |   2 +-
>  qapi/block-core.json                          |   4 +
>  tests/qemu-iotests/257.out                    | 112 ++++++-------
>  .../qemu-iotests/tests/backup-discard-source  | 151 ++++++++++++++++++
>  .../tests/backup-discard-source.out           |   5 +
>  13 files changed, 271 insertions(+), 70 deletions(-)
>  create mode 100755 tests/qemu-iotests/tests/backup-discard-source
>  create mode 100644 tests/qemu-iotests/tests/backup-discard-source.out
> 

Tested-by: Fiona Ebner <f.ebner@proxmox.com>