From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <linux-block@vger.kernel.org>, <axboe@kernel.dk>
Subject: Re: [PATCH 1/1] block: add sysfs entry for virt boundary mask
Date: Tue, 6 Apr 2021 11:16:11 +0300 [thread overview]
Message-ID: <c2c9444f-69cf-6af7-453d-2a053d56a049@nvidia.com> (raw)
In-Reply-To: <yq1v990ch7g.fsf@ca-mkp.ca.oracle.com>
On 4/6/2021 4:53 AM, Martin K. Petersen wrote:
> Max,
>
>> This entry will expose the bio vector alignment mask for a specific
>> block device.
> Looks fine except for the (page) that Chaitanya also pointed out.
thanks for the review. In blk-sysfs.c we see both "(page) or page". I'm
fine with Both.
Jens, can this be fixed during the merge to the preferred option please ?
>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>
next prev parent reply other threads:[~2021-04-06 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 13:20 [PATCH 1/1] block: add sysfs entry for virt boundary mask Max Gurtovoy
2021-04-05 17:40 ` Chaitanya Kulkarni
2021-04-06 1:46 ` Ming Lei
2021-04-06 1:53 ` Martin K. Petersen
2021-04-06 8:16 ` Max Gurtovoy [this message]
2021-04-06 15:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c9444f-69cf-6af7-453d-2a053d56a049@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.