From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Wang Yufen <wangyufen@huawei.com>,
aspriel@gmail.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, kvalo@kernel.org,
davem@davemloft.net
Cc: linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
arend@broadcom.com
Subject: Re: [PATCH v2] wifi: brcmfmac: Fix error return code in brcmf_sdio_download_firmware()
Date: Fri, 2 Dec 2022 20:13:57 +0100 [thread overview]
Message-ID: <c2fef52d-3e93-8489-f4f0-6d67d9f15ba1@broadcom.com> (raw)
In-Reply-To: <1669959342-27144-1-git-send-email-wangyufen@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On 12/2/2022 6:35 AM, Wang Yufen wrote:
> Fix to return a negative error code instead of 0 when
> brcmf_chip_set_active() fails. In addition, change the return
> value for brcmf_pcie_exit_download_state() to keep consistent.
>
> Fixes: d380ebc9b6fb ("brcmfmac: rename chip download functions")
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
> v2: change the error code from EINVAL to EIO, as Arend suggessted
Thanks.
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 +-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
next prev parent reply other threads:[~2022-12-02 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 5:35 [PATCH v2] wifi: brcmfmac: Fix error return code in brcmf_sdio_download_firmware() Wang Yufen
2022-12-02 19:13 ` Arend van Spriel [this message]
2022-12-08 14:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2fef52d-3e93-8489-f4f0-6d67d9f15ba1@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=arend@broadcom.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.