All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: kernel@pengutronix.de, Sergey Kozlov <serjk@netup.ru>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH v3 07/32] media: netup_unidvb: Follow renaming of SPI "master" to "controller"
Date: Wed,  7 Feb 2024 19:40:21 +0100	[thread overview]
Message-ID: <c37fceef8c631c5b49538f3f143573b605fc2c24.1707324794.git.u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <cover.1707324793.git.u.kleine-koenig@pengutronix.de>

In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"")
some functions and struct members were renamed. To not break all drivers
compatibility macros were provided.

To be able to remove these compatibility macros push the renaming into
this driver.

Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 .../media/pci/netup_unidvb/netup_unidvb_spi.c | 48 +++++++++----------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c b/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
index 526042d8afae..e90aa1c1584c 100644
--- a/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
+++ b/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
@@ -35,7 +35,7 @@ struct netup_spi_regs {
 
 struct netup_spi {
 	struct device			*dev;
-	struct spi_master		*master;
+	struct spi_controller		*ctlr;
 	struct netup_spi_regs __iomem	*regs;
 	u8 __iomem			*mmio;
 	spinlock_t			lock;
@@ -78,7 +78,7 @@ irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
 	reg = readw(&spi->regs->control_stat);
 	if (!(reg & NETUP_SPI_CTRL_IRQ)) {
 		spin_unlock_irqrestore(&spi->lock, flags);
-		dev_dbg(&spi->master->dev,
+		dev_dbg(&spi->ctlr->dev,
 			"%s(): not mine interrupt\n", __func__);
 		return IRQ_NONE;
 	}
@@ -88,15 +88,15 @@ irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
 	spi->state = SPI_STATE_DONE;
 	wake_up(&spi->waitq);
 	spin_unlock_irqrestore(&spi->lock, flags);
-	dev_dbg(&spi->master->dev,
+	dev_dbg(&spi->ctlr->dev,
 		"%s(): SPI interrupt handled\n", __func__);
 	return IRQ_HANDLED;
 }
 
-static int netup_spi_transfer(struct spi_master *master,
+static int netup_spi_transfer(struct spi_controller *ctlr,
 			      struct spi_message *msg)
 {
-	struct netup_spi *spi = spi_master_get_devdata(master);
+	struct netup_spi *spi = spi_controller_get_devdata(ctlr);
 	struct spi_transfer *t;
 	int result = 0;
 	u32 tr_size;
@@ -131,7 +131,7 @@ static int netup_spi_transfer(struct spi_master *master,
 				NETUP_SPI_CTRL_START |
 				(frag_last ? NETUP_SPI_CTRL_LAST_CS : 0),
 				&spi->regs->control_stat);
-			dev_dbg(&spi->master->dev,
+			dev_dbg(&spi->ctlr->dev,
 				"%s(): control_stat 0x%04x\n",
 				__func__, readw(&spi->regs->control_stat));
 			wait_event_timeout(spi->waitq,
@@ -144,11 +144,11 @@ static int netup_spi_transfer(struct spi_master *master,
 				}
 			} else {
 				if (spi->state == SPI_STATE_START) {
-					dev_dbg(&spi->master->dev,
+					dev_dbg(&spi->ctlr->dev,
 						"%s(): transfer timeout\n",
 						__func__);
 				} else {
-					dev_dbg(&spi->master->dev,
+					dev_dbg(&spi->ctlr->dev,
 						"%s(): invalid state %d\n",
 						__func__, spi->state);
 				}
@@ -161,7 +161,7 @@ static int netup_spi_transfer(struct spi_master *master,
 	}
 done:
 	msg->status = result;
-	spi_finalize_current_message(master);
+	spi_finalize_current_message(ctlr);
 	return result;
 }
 
@@ -172,30 +172,30 @@ static int netup_spi_setup(struct spi_device *spi)
 
 int netup_spi_init(struct netup_unidvb_dev *ndev)
 {
-	struct spi_master *master;
+	struct spi_controller *ctlr;
 	struct netup_spi *nspi;
 
-	master = devm_spi_alloc_master(&ndev->pci_dev->dev,
-		sizeof(struct netup_spi));
-	if (!master) {
+	ctlr = devm_spi_alloc_master(&ndev->pci_dev->dev,
+					 sizeof(struct netup_spi));
+	if (!ctlr) {
 		dev_err(&ndev->pci_dev->dev,
 			"%s(): unable to alloc SPI master\n", __func__);
 		return -EINVAL;
 	}
-	nspi = spi_master_get_devdata(master);
-	master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST;
-	master->bus_num = -1;
-	master->num_chipselect = 1;
-	master->transfer_one_message = netup_spi_transfer;
-	master->setup = netup_spi_setup;
+	nspi = spi_controller_get_devdata(ctlr);
+	ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST;
+	ctlr->bus_num = -1;
+	ctlr->num_chipselect = 1;
+	ctlr->transfer_one_message = netup_spi_transfer;
+	ctlr->setup = netup_spi_setup;
 	spin_lock_init(&nspi->lock);
 	init_waitqueue_head(&nspi->waitq);
-	nspi->master = master;
+	nspi->ctlr = ctlr;
 	nspi->regs = (struct netup_spi_regs __iomem *)(ndev->bmmio0 + 0x4000);
 	writew(2, &nspi->regs->clock_divider);
 	writew(NETUP_UNIDVB_IRQ_SPI, ndev->bmmio0 + REG_IMASK_SET);
 	ndev->spi = nspi;
-	if (spi_register_master(master)) {
+	if (spi_register_controller(ctlr)) {
 		ndev->spi = NULL;
 		dev_err(&ndev->pci_dev->dev,
 			"%s(): unable to register SPI bus\n", __func__);
@@ -207,8 +207,8 @@ int netup_spi_init(struct netup_unidvb_dev *ndev)
 		ndev->pci_bus,
 		ndev->pci_slot,
 		ndev->pci_func);
-	if (!spi_new_device(master, &netup_spi_board)) {
-		spi_unregister_master(master);
+	if (!spi_new_device(ctlr, &netup_spi_board)) {
+		spi_unregister_controller(ctlr);
 		ndev->spi = NULL;
 		dev_err(&ndev->pci_dev->dev,
 			"%s(): unable to create SPI device\n", __func__);
@@ -227,7 +227,7 @@ void netup_spi_release(struct netup_unidvb_dev *ndev)
 	if (!spi)
 		return;
 
-	spi_unregister_master(spi->master);
+	spi_unregister_controller(spi->ctlr);
 	spin_lock_irqsave(&spi->lock, flags);
 	reg = readw(&spi->regs->control_stat);
 	writew(reg | NETUP_SPI_CTRL_IRQ, &spi->regs->control_stat);
-- 
2.43.0


  parent reply	other threads:[~2024-02-07 18:43 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 18:40 [PATCH v3 00/32] spi: get rid of some legacy macros Uwe Kleine-König
2024-02-07 18:40 ` Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 01/32] fpga: ice40-spi: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-02-08 10:09   ` Jonathan Cameron
2024-02-08 10:28     ` Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 02/32] ieee802154: ca8210: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 03/32] iio: adc: ad_sigma_delta: " Uwe Kleine-König
2024-02-08  8:14   ` Nuno Sá
2024-02-07 18:40 ` [PATCH v3 04/32] Input: pxspad - follow " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 05/32] Input: synaptics-rmi4 " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 06/32] media: mgb4: Follow " Uwe Kleine-König
2024-02-07 18:40 ` Uwe Kleine-König [this message]
2024-02-07 18:40 ` [PATCH v3 08/32] media: usb/msi2500: " Uwe Kleine-König
2024-02-12  8:50   ` Hans Verkuil
2024-02-07 18:40 ` [PATCH v3 09/32] media: v4l2-subdev: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 10/32] misc: gehc-achc: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 11/32] mmc: mmc_spi: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 12/32] mtd: dataflash: " Uwe Kleine-König
2024-02-07 18:40   ` Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 13/32] net: ks8851: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 14/32] net: vertexcom: mse102x: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 15/32] platform/chrome: cros_ec_spi: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 16/32] spi: bitbang: " Uwe Kleine-König
2024-02-07 18:40   ` Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 17/32] spi: cadence-quadspi: Don't emit error message on allocation error Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 18/32] spi: cadence-quadspi: Follow renaming of SPI "master" to "controller" Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 19/32] spi: cavium: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 20/32] spi: geni-qcom: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 21/32] spi: loopback-test: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 22/32] spi: slave-mt27xx: " Uwe Kleine-König
2024-02-07 18:40   ` Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 23/32] spi: spidev: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 24/32] staging: fbtft: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 25/32] staging: greybus: spi: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 26/32] tpm_tis_spi: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 27/32] usb: gadget: max3420_udc: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 28/32] video: fbdev: mmp: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 29/32] wifi: libertas: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 30/32] spi: fsl-lib: " Uwe Kleine-König
2024-02-07 18:40 ` [PATCH v3 31/32] spi: Drop compat layer from renaming " Uwe Kleine-König
2024-02-09 15:24   ` Andy Shevchenko
2024-02-09 15:48     ` Mark Brown
2024-02-09 15:54       ` Andy Shevchenko
2024-02-07 18:40 ` [PATCH v3 32/32] Documentation: spi: Update documentation for " Uwe Kleine-König
2024-02-09 15:23   ` Andy Shevchenko
2024-02-08 21:21 ` [PATCH v3 00/32] spi: get rid of some legacy macros Mark Brown
2024-02-08 21:21   ` Mark Brown
2024-03-25  1:54 ` patchwork-bot+chrome-platform
2024-03-25  1:54   ` patchwork-bot+chrome-platform
2024-03-25  2:13 ` patchwork-bot+chrome-platform
2024-03-25  2:13   ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c37fceef8c631c5b49538f3f143573b605fc2c24.1707324794.git.u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=broonie@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=serjk@netup.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.