Re: [PATCH v1 0/6] media: nxp: imx7-media-csi: Move to subdev active state

From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org
Cc: Rui Miguel Silva <rmfrfs@gmail.com>,
	Paul Elder <paul.elder@ideasonboard.com>,
	Adam Ford <aford173@gmail.com>,
	kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH v1 0/6] media: nxp: imx7-media-csi: Move to subdev active state
Date: Fri, 27 Jan 2023 12:41:26 +0100	[thread overview]
Message-ID: <c38b1842a6e3042c66ab885ea8e46d832d238ce4.camel@puri.sm> (raw)
In-Reply-To: <20230127022715.27234-1-laurent.pinchart@ideasonboard.com>

Am Freitag, dem 27.01.2023 um 04:27 +0200 schrieb Laurent Pinchart:
> Hello,
> 
> This small series moves the imx7-mipi-csi driver to use the subdev
> active state. Patches 1/6 to 5/6 are small preparatory cleanups, with
> the main change in 6/6.
> 
> I haven't tested the series yet as I need to dig up the hardware
> first.
> Adam, you offered to test the similar imx-mipi-csis series I've sent
> recently on the i.MX8MM, would you be able to test this one at the
> same
> time ?
> 

a first test of streaming frames on imx8mq with these patches + your
inline fix works fine. just so you know. I can keep testing possible
future revisions. thanks a lot!

                          martin

ps. I know something similar needs to be done for the imx8mq mipi csi
driver.

> Laurent Pinchart (6):
>   media: imx: imx7-media-csi: Drop imx7_csi.cc field
>   media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format()
>   media: imx: imx7-media-csi: Drop unneeded check when starting
>     streaming
>   media: imx: imx7-media-csi: Drop unneeded src_sd check
>   media: imx: imx7-media-csi: Drop unneeded pad checks
>   media: imx: imx7-media-csi: Use V4L2 subdev active state
> 
>  drivers/media/platform/nxp/imx7-media-csi.c | 208 ++++++------------
> --
>  1 file changed, 58 insertions(+), 150 deletions(-)
> 
> 
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2