All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: wangweidong.a@awinic.com, lgirdwood@gmail.com,
	broonie@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	perex@perex.cz, tiwai@suse.com, rf@opensource.cirrus.com,
	shumingf@realtek.com, ryans.lee@analog.com, 13916275206@139.com,
	herve.codina@bootlin.com, ckeepax@opensource.cirrus.com,
	doug@schmorgal.com, fido_max@inbox.ru, povik+lin@cutebit.org,
	liweilei@awinic.com, yijiangtao@awinic.com,
	colin.i.king@gmail.com, trix@redhat.com,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: zhangjianming@awinic.com
Subject: Re: [PATCH V3 5/5] ASoC: codecs: aw88261 chip register file, Kconfig and Makefile
Date: Sat, 29 Jul 2023 13:29:29 +0200	[thread overview]
Message-ID: <c4cc2dfa-ca3f-1d51-8a3b-a131ccc54d03@linaro.org> (raw)
In-Reply-To: <20230729091223.193466-6-wangweidong.a@awinic.com>

On 29/07/2023 11:12, wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
> 
> Mainly includes aw88261 register table, Makefile and Kconfig.
> 
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
>  sound/soc/codecs/Kconfig               |  15 +
>  sound/soc/codecs/Makefile              |   3 +
>  sound/soc/codecs/aw88261/aw88261_reg.h | 374 +++++++++++++++++++++++++
>  3 files changed, 392 insertions(+)
>  create mode 100644 sound/soc/codecs/aw88261/aw88261_reg.h
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index c2de4ee72183..1e3526812cc8 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -55,6 +55,7 @@ config SND_SOC_ALL_CODECS
>  	imply SND_SOC_ALC5632
>  	imply SND_SOC_AW8738
>  	imply SND_SOC_AW88395
> +	imply SND_SOC_AW88261
>  	imply SND_SOC_BT_SCO
>  	imply SND_SOC_BD28623
>  	imply SND_SOC_CHV3_CODEC
> @@ -640,6 +641,20 @@ config SND_SOC_AW88395
>  	  digital Smart K audio amplifier with an integrated 10V
>  	  smart boost convert.
>  
> +config SND_SOC_AW88261
> +	tristate "Soc Audio for awinic aw88261"
> +	depends on I2C
> +	select CRC8
> +	select REGMAP_I2C
> +	select GPIOLIB
> +	select SND_SOC_AW88395_LIB
> +	help
> +	  This option enables support for aw88261 Smart PA.
> +	  The awinic AW88261 is an I2S/TDM input, high efficiency
> +	  digital Smart K audio amplifier. The output voltage of
> +	  boost converter can be adjusted smartly according to
> +	  the input amplitude.
> +
>  config SND_SOC_BD28623
>  	tristate "ROHM BD28623 CODEC"
>  	help
> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
> index b48a9a323b84..9df43de213f0 100644
> --- a/sound/soc/codecs/Makefile
> +++ b/sound/soc/codecs/Makefile
> @@ -49,6 +49,8 @@ snd-soc-aw8738-objs := aw8738.o
>  snd-soc-aw88395-lib-objs := aw88395/aw88395_lib.o
>  snd-soc-aw88395-objs := aw88395/aw88395.o \
>  			aw88395/aw88395_device.o
> +snd-soc-aw88261-objs := aw88261/aw88261.o \
> +			aw88261/aw88261_device.o
>  snd-soc-bd28623-objs := bd28623.o
>  snd-soc-bt-sco-objs := bt-sco.o
>  snd-soc-chv3-codec-objs := chv3-codec.o
> @@ -431,6 +433,7 @@ obj-$(CONFIG_SND_SOC_ARIZONA)	+= snd-soc-arizona.o
>  obj-$(CONFIG_SND_SOC_AW8738)	+= snd-soc-aw8738.o
>  obj-$(CONFIG_SND_SOC_AW88395_LIB) += snd-soc-aw88395-lib.o
>  obj-$(CONFIG_SND_SOC_AW88395)	+=snd-soc-aw88395.o
> +obj-$(CONFIG_SND_SOC_AW88261)	+=snd-soc-aw88261.o
>  obj-$(CONFIG_SND_SOC_BD28623)	+= snd-soc-bd28623.o
>  obj-$(CONFIG_SND_SOC_BT_SCO)	+= snd-soc-bt-sco.o
>  obj-$(CONFIG_SND_SOC_CHV3_CODEC) += snd-soc-chv3-codec.o
> diff --git a/sound/soc/codecs/aw88261/aw88261_reg.h b/sound/soc/codecs/aw88261/aw88261_reg.h
> new file mode 100644
> index 000000000000..7ef128a3e6ee
> --- /dev/null
> +++ b/sound/soc/codecs/aw88261/aw88261_reg.h
> @@ -0,0 +1,374 @@
> +// SPDX-License-Identifier: GPL-2.0-only

If you add the headers now, it means they are not used in any previous
patches. Therefore drop the header - it is useless.

Best regards,
Krzysztof


  reply	other threads:[~2023-07-29 11:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29  9:12 [PATCH V3 0/5] ASoC: codecs: Add awinic AW88261 audio amplifier driver wangweidong.a
2023-07-29  9:12 ` [PATCH V3 1/5] ASoC: dt-bindings: Add schema for "awinic,aw88261" wangweidong.a
2023-07-29 11:18   ` Krzysztof Kozlowski
2023-07-29  9:12 ` [PATCH V3 2/5] ASoC: codecs: Add code for bin parsing compatible with aw88261 wangweidong.a
2023-07-29  9:12 ` [PATCH V3 3/5] ASoC: codecs: Add aw88261 amplifier driver wangweidong.a
2023-07-29 11:22   ` Krzysztof Kozlowski
2023-07-31  6:39     ` wangweidong.a
2023-07-29  9:12 ` [PATCH V3 4/5] ASoC: codecs: aw88261 device related operation functions wangweidong.a
2023-07-29 11:28   ` Krzysztof Kozlowski
2023-07-31  6:41     ` wangweidong.a
2023-07-31  6:51       ` Krzysztof Kozlowski
2023-07-31  7:43         ` wangweidong.a
2023-07-29  9:12 ` [PATCH V3 5/5] ASoC: codecs: aw88261 chip register file, Kconfig and Makefile wangweidong.a
2023-07-29 11:29   ` Krzysztof Kozlowski [this message]
2023-07-31  6:44     ` wangweidong.a

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4cc2dfa-ca3f-1d51-8a3b-a131ccc54d03@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=13916275206@139.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=colin.i.king@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=doug@schmorgal.com \
    --cc=fido_max@inbox.ru \
    --cc=herve.codina@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liweilei@awinic.com \
    --cc=perex@perex.cz \
    --cc=povik+lin@cutebit.org \
    --cc=rf@opensource.cirrus.com \
    --cc=robh+dt@kernel.org \
    --cc=ryans.lee@analog.com \
    --cc=shumingf@realtek.com \
    --cc=tiwai@suse.com \
    --cc=trix@redhat.com \
    --cc=wangweidong.a@awinic.com \
    --cc=yijiangtao@awinic.com \
    --cc=zhangjianming@awinic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.