From: Jan Beulich <jbeulich@suse.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen: Create EFI_VENDOR directory
Date: Mon, 22 Mar 2021 15:52:43 +0100 [thread overview]
Message-ID: <c5736ca0-de24-bac7-f1d9-3f90df997454@suse.com> (raw)
In-Reply-To: <20210322133301.11308-1-jandryuk@gmail.com>
On 22.03.2021 14:33, Jason Andryuk wrote:
> make install-xen fails when EFI_VENDOR is set (=fedora) with:
> install: cannot create regular file '/home/user/xen/dist/install/boot/efi/efi/fedora/xen-4.15.0-rc.efi': No such file or directory
>
> Create the EFI_VENDOR directory so xen.efi can be installed within.
>
> This removes the need for Fedora and Qubes xen.spec files to manually
> create the directory in advance.
While I'm not strictly against, I'd like to point out that it was
deliberate to not create this directory here. I also didn't expect
anyone's xen.spec to do so. Instead I'd expect the distro to create
it during OS installation. If this was a bad assumption, I'd prefer
if the commit message here could point out why such an expectation
won't hold in general.
Jan
next prev parent reply other threads:[~2021-03-22 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 13:33 [PATCH] xen: Create EFI_VENDOR directory Jason Andryuk
2021-03-22 13:38 ` for-4.15 " Andrew Cooper
2021-03-22 14:01 ` Ian Jackson
2021-03-22 14:52 ` Jan Beulich [this message]
2021-03-22 14:59 ` Andrew Cooper
2021-03-22 15:15 ` Jan Beulich
2021-03-22 15:36 ` Jason Andryuk
2021-03-22 16:53 ` Jan Beulich
2021-03-22 17:08 ` Andrew Cooper
2021-03-23 7:23 ` Jan Beulich
2021-03-23 12:34 ` Jason Andryuk
2021-03-23 13:36 ` Jan Beulich
2021-03-23 13:41 ` Ian Jackson
2021-03-23 15:31 ` Jan Beulich
2021-03-23 15:58 ` Michael Young
2021-03-23 17:32 ` Roman Shaposhnik
2021-03-23 17:30 ` Roman Shaposhnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5736ca0-de24-bac7-f1d9-3f90df997454@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jandryuk@gmail.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.