Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack

From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/omap: Rework the rotation-on-crtc hack
Date: Fri, 4 Aug 2017 12:57:39 +0300	[thread overview]
Message-ID: <c5aca807-2e92-9165-746b-9108167e35aa@ti.com> (raw)
In-Reply-To: <0348f52a-94d4-4174-2060-6104e145acfa@linux.intel.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 1559 bytes --]

Hi,

> Here you go, compile tested version. :)
> ----8<----
> I want/need to rework the core property handling, and this hack is
> getting in the way. But since it's a non-standard propety only used by
> legacy userspace we know that this will only every be called from
> ioctl code. And never on some other free-standing state struct, where
> this old hack wouldn't work either.
> 
> v2: don't forget zorder and get_property!
> 
> v3: Shadow the legacy state to avoid locking issues in get_property
> (Maarten).
> 
> v4: Review from Laurent
> - Move struct omap_crtc_state into omap_crtc.c
> - Clean up comments.
> - Don't forget to copy the shadowed state over on duplicate.
> 
> v5: Don't forget to update the reset handler (Maarten).
> v6: Update omap_crtc_state shadow values in omap_crtc_atomic_check (Maarten).
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (v4)
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_crtc.c | 118 +++++++++++++++++++++++++-----------
>  1 file changed, 81 insertions(+), 37 deletions(-)

This makes all the CRTC properties disappear...

This doesn't depend on anything in drm-next, does it? I'm currently on
v4.13-rc3. I'll look a bit more on what's going on later today.

 Tomi

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel