From: pharish@codeaurora.org
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
mka@chromium.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
rjliao@codeaurora.org, hbandi@codeaurora.org,
abhishekpandit@chromium.org, mcchou@chromium.org,
saluvala@codeaurora.org
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF
Date: Tue, 07 Dec 2021 11:09:35 +0530 [thread overview]
Message-ID: <c767becd1ded90dc0cf4b76f38d779b0@codeaurora.org> (raw)
In-Reply-To: <A078C973-AAAF-4BD2-85DA-F8017CE89012@holtmann.org>
On 2021-11-26 00:12, Marcel Holtmann wrote:
> Hi,
>
>> This change stops IBS timers during BT OFF.
>>
>> Signed-off-by: pharish <pharish@codeaurora.org>
>
> clear name please.
[Harish]: will update
>
>> ---
>> drivers/bluetooth/hci_qca.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index dd768a8..6f44b26 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev)
>> hu->hdev->hw_error = NULL;
>> hu->hdev->cmd_timeout = NULL;
>>
>> + mod_timer(&qca->tx_idle_timer, 0);
>> + mod_timer(&qca->wake_retrans_timer, 0);
>> +
>
> And I would really prefer if this gets changed to use a workqueue
> instead of a timer.
[Harish]: The full implementation of IBS is based on timers
to that reason I have switched to timers.
>
> Regards
>
> Marcel
next prev parent reply other threads:[~2021-12-07 5:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 13:17 [PATCH v1] Bluetooth: hci_qca: Optimizations in init sequence for WCN6750 pharish
2021-11-25 13:17 ` [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF pharish
2021-11-25 18:42 ` Marcel Holtmann
2021-12-07 5:39 ` pharish [this message]
2021-11-25 18:44 ` [PATCH v1] Bluetooth: hci_qca: Optimizations in init sequence for WCN6750 Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c767becd1ded90dc0cf4b76f38d779b0@codeaurora.org \
--to=pharish@codeaurora.org \
--cc=abhishekpandit@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
--cc=saluvala@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.