Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX

From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: Marek Vasut <marex@denx.de>, <linux-arm-kernel@lists.infradead.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Patrick Delaunay <patrick.delaunay@st.com>,
	Patrice Chotard <patrice.chotard@st.com>
Subject: Re: [PATCH 1/2] ARM: dts: stm32: Fix GPIO hog flags on DHCOM PicoITX
Date: Thu, 14 Jan 2021 16:11:25 +0100	[thread overview]
Message-ID: <c893ad3e-dba2-e1b2-ed7a-24937532d0e6@foss.st.com> (raw)
In-Reply-To: <20201229175521.268234-1-marex@denx.de>

Hi Marek

On 12/29/20 6:55 PM, Marek Vasut wrote:
> The GPIO hog flags are ignored by gpiolib-of.c now, set the flags to 0.
> Due to a change in gpiolib-of.c, setting flags to GPIO_ACTIVE_LOW and
> using output-low DT property leads to the GPIO being set high instead.
> 
> Fixes: ac68793f49de ("ARM: dts: stm32: Add DHCOM based PicoITX board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>   arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> index 25528a1c096f..757707766fa0 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-picoitx.dtsi
> @@ -49,7 +49,7 @@ &gpioa {
>   	 */
>   	usb-port-power-hog {

On my tree this node is "usb-port-power". Do you want to update the node 
name too ? I can do it directly during the merge if you want.
(Note, it is the case for DRC02 hog update).

regards
alex

>   		gpio-hog;
> -		gpios = <13 GPIO_ACTIVE_LOW>;
> +		gpios = <13 0>;
>   		output-low;
>   		line-name = "usb-port-power";
>   	};
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel