Re: [PATCH v7 0/7] Add interrupt support to FPGA DFL drivers

From: Tom Rix <trix@redhat.com>
To: Xu Yilun <yilun.xu@intel.com>,
	mdf@kernel.org, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: bhu@redhat.com, mtosatti@redhat.com, gregkh@linuxfoundation.org,
	jun.j.tian@intel.com, hao.wu@intel.com
Subject: Re: [PATCH v7 0/7] Add interrupt support to FPGA DFL drivers
Date: Mon, 22 Jun 2020 05:27:20 -0700	[thread overview]
Message-ID: <c9a33ee6-67f2-36b8-0870-ebc038b929ce@redhat.com> (raw)
In-Reply-To: <20200622064806.GA5101@yilunxu-OptiPlex-7050>

In addition to reviewing, I have run these changes on the pac a10 card and while i do not have an afu using interrupts, I have exercised some of the new interfaces.

The most useful i have submitted to selftests drivers/fpga.  In the future, this would be a good place to put other fpga unit tests. 

The selftest patch depends on this change.

So you can also add

Tested-by: Tom Rix <trix@redhat.com>

Tom

On 6/21/20 11:48 PM, Xu Yilun wrote:
> Hi Moritz:
>
> Could you please help review the patchset when you have time?
>
> You have already reviewed the first 3 patches some time ago. The
> comments are all fixed. Hao and Redhat guys also have done several
> rounds of review. The patches are all Acked-by Hao, reviewed by
> Marcelo & Tom.
>
> There is little change to the code for several months, seems it stays
> ready and just need your final Ack.
>
> Actually this is the last feature for our first generation PAC A10 Card,
> and is important for users to have the full support.
>
> We really need your help on code review ...
>
> Many thanks!
> Yilun
>
> On Tue, Jun 16, 2020 at 12:08:41PM +0800, Xu Yilun wrote:
>> This patchset add interrupt support to FPGA DFL drivers.
>>
>> With these patches, DFL driver will parse and assign interrupt resources
>> for enumerated feature devices and their sub features.
>>
>> This patchset also introduces a set of APIs for user to monitor DFL
>> interrupts. Three sub features (DFL FME error, DFL AFU error and user
>> interrupt) drivers now support these APIs.
>>
>> Patch #1: DFL framework change. Accept interrupt info input from DFL bus
>>           driver, and add interrupt parsing and assignment for feature
>>           sub devices.
>> Patch #2: DFL pci driver change, add interrupt info on DFL enumeration.
>> Patch #3: DFL framework change. Add helper functions for feature sub
>>           device drivers to handle interrupt and notify users.
>> Patch #4: Add interrupt support for AFU error reporting sub feature.
>> Patch #5: Add interrupt support for FME global error reporting sub
>>           feature.
>> Patch #6: Add interrupt support for a new sub feature, to handle user
>>           interrupts implemented in AFU.
>> Patch #7: Documentation for DFL interrupt handling.
>>
>> Main changes from v1:
>>  - Early validating irq table for each feature in parse_feature_irq()
>>    in Patch #1.
>>  - Changes IOCTL interfaces. use DFL_FPGA_FME/PORT_XXX_GET_IRQ_NUM
>>    instead of DFL_FPGA_FME/PORT_XXX_GET_INFO, delete flag field for
>>    DFL_FPGA_FME/PORT_XXX_SET_IRQ param
>>
>> Main changes from v2:
>>  - put parse_feature_irqs() inside create_feature_instance().
>>  - refines code for dfl_fpga_set_irq_triggers, delete local variable j.
>>  - put_user() instead of copy_to_user() for DFL_FPGA_XXX_GET_IRQ_NUM IOCTL
>>
>> Main changes from v3:
>>  - rebased to 5.7-rc1.
>>  - fail the dfl enumeration when irq parsing error happens.
>>  - Add 2 helper functions in dfl.c to handle generic irq ioctls in feature
>>    drivers.
>>
>> Main changes from v4:
>>  - Minor fixes for Hao's comments.
>>
>> Main changes from v5:
>>  - Remove unnecessary type casting in Patch #1 & #3.
>>  - Minor fixes for Moritz's comments.
>>
>> Main changes from v6:
>>  - Add the header file <linux/interrupt.h> for Patch #1, to fix build
>>    error on ARCH=xtensa
>>  - Minor fixes in Patch #2 & #3.
>>
>> Xu Yilun (7):
>>   fpga: dfl: parse interrupt info for feature devices on enumeration
>>   fpga: dfl: pci: add irq info for feature devices enumeration
>>   fpga: dfl: introduce interrupt trigger setting API
>>   fpga: dfl: afu: add interrupt support for port error reporting
>>   fpga: dfl: fme: add interrupt support for global error reporting
>>   fpga: dfl: afu: add AFU interrupt support
>>   Documentation: fpga: dfl: add descriptions for interrupt related
>>     interfaces.
>>
>>  Documentation/fpga/dfl.rst    |  19 +++
>>  drivers/fpga/dfl-afu-error.c  |  17 +++
>>  drivers/fpga/dfl-afu-main.c   |  32 +++++
>>  drivers/fpga/dfl-fme-error.c  |  18 +++
>>  drivers/fpga/dfl-fme-main.c   |   6 +
>>  drivers/fpga/dfl-pci.c        |  76 +++++++++--
>>  drivers/fpga/dfl.c            | 310 ++++++++++++++++++++++++++++++++++++++++++
>>  drivers/fpga/dfl.h            |  57 ++++++++
>>  include/uapi/linux/fpga-dfl.h |  82 +++++++++++
>>  9 files changed, 608 insertions(+), 9 deletions(-)
>>
>> -- 
>> 2.7.4