From: Julien Grall <julien@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
"Shawn Anastasio" <sanastasio@raptorengineering.com>
Subject: Re: [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation
Date: Mon, 4 Mar 2024 16:31:59 +0000 [thread overview]
Message-ID: <c9f92495-2c00-443f-bffd-1b09cb8a8c84@xen.org> (raw)
In-Reply-To: <20240304161041.3465897-2-andrew.cooper3@citrix.com>
Hi Andrew,
On 04/03/2024 16:10, Andrew Cooper wrote:
> It is daft to require all architectures to provide empty implementations of
> this functionality.
Oleksii recenlty sent a similar patch [1]. This was pushed back because
from naming, it sounds like the helpers ought to be non-empty on every
architecture.
It would be best if asm-generic provides a safe version of the helpers.
So my preference is to not have this patch. This can of course change if
I see an explanation why it is empty on Arm (I believe it should contain
csdb) and other arch would want the same.
Cheers,
[1]
5889d7a5fa81722472f95cc1448af0be8f359a7d.1707146506.git.oleksii.kurochko@gmail.com
--
Julien Grall
next prev parent reply other threads:[~2024-03-04 16:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 16:10 [PATCH 0/2] xen/nospec: Improvements Andrew Cooper
2024-03-04 16:10 ` [PATCH 1/2] xen/*/nospec: Provide common versions of evaluate_nospec/block_speculation Andrew Cooper
2024-03-04 16:31 ` Julien Grall [this message]
2024-03-04 16:41 ` Jan Beulich
2024-03-04 16:46 ` Julien Grall
2024-03-04 16:55 ` Jan Beulich
2024-03-04 17:07 ` Andrew Cooper
2024-03-04 17:40 ` Julien Grall
2024-03-04 17:50 ` Andrew Cooper
2024-03-05 15:15 ` Oleksii
2024-03-05 15:43 ` Jan Beulich
2024-03-05 15:47 ` Andrew Cooper
2024-03-05 18:56 ` Oleksii
2024-03-05 7:10 ` Jan Beulich
2024-03-04 16:47 ` Andrew Cooper
2024-03-04 16:45 ` Jan Beulich
2024-03-04 16:46 ` Andrew Cooper
2024-03-05 7:15 ` Jan Beulich
2024-03-05 7:34 ` Jan Beulich
2024-03-04 16:10 ` [PATCH 2/2] xen/nospec: Allow evaluate_nospec() to short circuit constant expressions Andrew Cooper
2024-03-05 7:30 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f92495-2c00-443f-bffd-1b09cb8a8c84@xen.org \
--to=julien@xen.org \
--cc=JBeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sanastasio@raptorengineering.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.