From: Martin Kurbanov <MMKurbanov@sberdevices.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v1 2/2] leds: add aw20xx driver
Date: Mon, 28 Nov 2022 17:45:22 +0000 [thread overview]
Message-ID: <cb9e8610-588e-6e56-ee33-8716008e7905@sberdevices.ru> (raw)
In-Reply-To: <ba4918dd-309c-5e6e-dc0a-eb5f1c4b1dfa@linaro.org>
On 25.11.2022 11:19, Krzysztof Kozlowski wrote:
>> + $ ls -l /sys/bus/i2c/devices/xxxx/pattern0/
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 clear_leds
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 fall_time
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 loop_begin
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 loop_end_on
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 max_breathing_level
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 min_breathing_level
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 mode
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 off_time
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 on_time
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 ramp
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 repeat
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 rise_time
>> + -r--r--r-- 1 root root 4096 Jan 1 00:00 running
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 select_leds
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 start
>> + -rw-r--r-- 1 root root 4096 Jan 1 00:00 toggle
>
> sysfs documentation goes to Documentation/ABI/
Should I add it to Documentation/ABI/testing/sysfs-class-led-driver-aw200xx?
Is my understanding correct?
Is KernelVersion parameter required?
>> + chip = devm_kzalloc(&client->dev,
>> + struct_size(chip, leds, count),
>
> sizeof(*chip)
Unfortunately, it will not work. Because I want to calculate the whole
size of chip structure, it has flexible array member inside.
--
Best Regards,
Kurbanov Martin
next prev parent reply other threads:[~2022-11-28 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 20:48 [PATCH v1 0/2] leds: add aw20xx driver Martin Kurbanov
2022-11-24 20:48 ` [PATCH v1 1/2] dt-bindings: leds: add binding for aw200xx Martin Kurbanov
2022-11-25 8:29 ` Krzysztof Kozlowski
2022-11-28 17:43 ` Martin Kurbanov
2022-12-02 16:41 ` Krzysztof Kozlowski
2022-12-02 18:53 ` Dmitry Rokosov
2022-12-03 10:44 ` Krzysztof Kozlowski
2022-11-24 20:48 ` [PATCH v1 2/2] leds: add aw20xx driver Martin Kurbanov
2022-11-25 2:37 ` kernel test robot
2022-11-25 8:19 ` Krzysztof Kozlowski
2022-11-28 17:45 ` Martin Kurbanov [this message]
2022-12-07 19:48 ` Pavel Machek
2022-11-25 19:17 ` kernel test robot
2022-12-07 19:49 ` Pavel Machek
2022-12-31 15:44 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb9e8610-588e-6e56-ee33-8716008e7905@sberdevices.ru \
--to=mmkurbanov@sberdevices.ru \
--cc=andy.shevchenko@gmail.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.