Re: [cip-dev][isar-cip-core][PATCH v4 0/2] swupdate-config: variables cleanup

From: "Jan Kiszka" <jan.kiszka@siemens.com>
To: Gylstorff Quirin <quirin.gylstorff@siemens.com>,
	cip-dev@lists.cip-project.org
Subject: Re: [cip-dev][isar-cip-core][PATCH v4 0/2] swupdate-config: variables cleanup
Date: Thu, 6 May 2021 16:52:54 +0200	[thread overview]
Message-ID: <cbda6d07-13e8-2b82-72ec-af3eb3c96a22@siemens.com> (raw)
In-Reply-To: <1dc8dbe6-6464-148e-6a70-9f797a76af06@siemens.com>

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

On 06.05.21 16:12, Gylstorff Quirin wrote:
> 
> 
> On 5/5/21 6:43 PM, Jan Kiszka wrote:
>> On 05.05.21 10:21, Q. Gylstorff wrote:
>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>
>>> This patch removes the variable U_BOOT from the swupdate-config.bbclass.
>>> It also adds the suffix `SWUPDATE` to the variable BOOTLOADER.
>>>
>>> If a custom u-boot is used in concunction with swupdate it is
>>> recommened to set `U_BOOT_CONFIG_PACKAGE` to '1'. This now adds
>>> a dependency from SWupdate to u-boot-{MACHINE}-config for installing
>>> fw_env.config.
>>>
>>> Changes in V2:
>>>   - fix typo in commit message
>>>   - use variable in kas/opt/*.yml
>>>
>>> Changes in V3:
>>>   - remove variable U_BOOT
>>>   - split into 2 commits
>>>
>>> Changes in V4:
>>>   - Add missing Changes log
>>>   - Correct commit message
>>>
>>> Quirin Gylstorff (2):
>>>    swupdate-config: remove variable U_BOOT
>>>    swupdate-config: add prefix to variable BOOTLOADER
>>>
>>>   classes/swupdate-config.bbclass      | 17 ++++++++++-------
>>>   kas/opt/ebg-secure-boot-snakeoil.yml |  2 +-
>>>   kas/opt/ebg-swu.yml                  |  4 ++--
>>>   kas/opt/qemu-swupdate.yml            |  2 +-
>>>   4 files changed, 14 insertions(+), 11 deletions(-)
>>>
>>
>> Thanks, applied to next.
>>
>> We may eventually also want to do a renaming of qemu-swupdate.yml to
>> qemu-amd64-swupdate.yml - just for the case that there will also be ARM
>> qemu target to demonstrate/test swupdate.
> 
> Alternative would be to change
> `
> -WKS_FILE = "qemu-amd64-${SWUPDATE_BOOTLOADER}.wks"
> +WKS_FILE = "${MACHINE}-${SWUPDATE_BOOTLOADER}.wks"
> `

Right, that file is only an option file anyway.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

[-- Attachment #2: Type: text/plain, Size: 428 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6436): https://lists.cip-project.org/g/cip-dev/message/6436
Mute This Topic: https://lists.cip-project.org/mt/82599604/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-