From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 11/22] btrfs-progs: qgroup-verify: scan extents based on block groups
Date: Wed, 1 Dec 2021 13:17:05 -0500 [thread overview]
Message-ID: <cbdfe7c345af59922480ffabbcf045d75aac9202.1638382588.git.josef@toxicpanda.com> (raw)
In-Reply-To: <cover.1638382588.git.josef@toxicpanda.com>
When we switch to per-block group extent roots we'll need to scan each
individual extent root. To make this easier in the future go ahead and
use the range of the block groups to scan the extents.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
check/qgroup-verify.c | 32 ++++++++++++++++++++++++--------
1 file changed, 24 insertions(+), 8 deletions(-)
diff --git a/check/qgroup-verify.c b/check/qgroup-verify.c
index 0813b841..45007d8c 100644
--- a/check/qgroup-verify.c
+++ b/check/qgroup-verify.c
@@ -1400,6 +1400,7 @@ static bool is_bad_qgroup(struct qgroup_count *count)
*/
int qgroup_verify_all(struct btrfs_fs_info *info)
{
+ struct rb_node *n;
int ret;
bool found_err = false;
bool skip_err = false;
@@ -1430,10 +1431,17 @@ int qgroup_verify_all(struct btrfs_fs_info *info)
/*
* Put all extent refs into our rbtree
*/
- ret = scan_extents(info, 0, ~0ULL);
- if (ret) {
- fprintf(stderr, "ERROR: while scanning extent tree: %d\n", ret);
- goto out;
+ for (n = rb_first(&info->block_group_cache_tree); n; n = rb_next(n)) {
+ struct btrfs_block_group *bg;
+
+ bg = rb_entry(n, struct btrfs_block_group, cache_node);
+ ret = scan_extents(info, bg->start,
+ bg->start + bg->length - 1);
+ if (ret) {
+ fprintf(stderr, "ERROR: while scanning extent tree: %d\n",
+ ret);
+ goto out;
+ }
}
ret = map_implied_refs(info);
@@ -1507,6 +1515,7 @@ static void print_subvol_info(u64 subvolid, u64 bytenr, u64 num_bytes,
int print_extent_state(struct btrfs_fs_info *info, u64 subvol)
{
+ struct rb_node *n;
int ret;
tree_blocks = ulist_alloc(0);
@@ -1519,10 +1528,17 @@ int print_extent_state(struct btrfs_fs_info *info, u64 subvol)
/*
* Put all extent refs into our rbtree
*/
- ret = scan_extents(info, 0, ~0ULL);
- if (ret) {
- fprintf(stderr, "ERROR: while scanning extent tree: %d\n", ret);
- goto out;
+ for (n = rb_first(&info->block_group_cache_tree); n; n = rb_next(n)) {
+ struct btrfs_block_group *bg;
+
+ bg = rb_entry(n, struct btrfs_block_group, cache_node);
+ ret = scan_extents(info, bg->start,
+ bg->start + bg->length - 1);
+ if (ret) {
+ fprintf(stderr, "ERROR: while scanning extent tree: %d\n",
+ ret);
+ goto out;
+ }
}
ret = map_implied_refs(info);
--
2.26.3
next prev parent reply other threads:[~2021-12-01 18:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 18:16 [PATCH v2 00/22] btrfs-progs: extent tree v2 support, global roots Josef Bacik
2021-12-01 18:16 ` [PATCH v2 01/22] btrfs-progs: common: allow users to select extent-tree-v2 option Josef Bacik
2021-12-01 18:16 ` [PATCH v2 02/22] btrfs-progs: add definitions for the block group tree Josef Bacik
2021-12-01 18:16 ` [PATCH v2 03/22] btrfs-progs: add on disk pointers to global tree ids Josef Bacik
2021-12-01 18:16 ` [PATCH v2 04/22] btrfs-progs: add support for loading the block group root Josef Bacik
2021-12-01 18:16 ` [PATCH v2 05/22] btrfs-progs: add print support for the block group tree Josef Bacik
2021-12-01 18:17 ` [PATCH v2 06/22] btrfs-progs: mkfs: use the btrfs_block_group_root helper Josef Bacik
2021-12-01 18:17 ` [PATCH v2 07/22] btrfs-progs: check-lowmem: " Josef Bacik
2021-12-01 18:17 ` [PATCH v2 08/22] btrfs-progs: handle no bg item in extent tree for free space tree Josef Bacik
2021-12-01 18:17 ` [PATCH v2 09/22] btrfs-progs: mkfs: add support for the block group tree Josef Bacik
2021-12-01 18:17 ` [PATCH v2 10/22] btrfs-progs: check: add block group tree support Josef Bacik
2021-12-01 18:17 ` Josef Bacik [this message]
2021-12-01 18:17 ` [PATCH v2 12/22] btrfs-progs: check: make free space tree validation extent tree v2 aware Josef Bacik
2021-12-01 18:17 ` [PATCH v2 13/22] btrfs-progs: check: add helper to reinit the root based on a key Josef Bacik
2021-12-01 18:17 ` [PATCH v2 14/22] btrfs-progs: check: handle the block group tree properly Josef Bacik
2021-12-01 18:17 ` [PATCH v2 15/22] btrfs-progs: load the number of global roots into the fs_info Josef Bacik
2021-12-01 18:17 ` [PATCH v2 16/22] btrfs-progs: handle the per-block group global root id Josef Bacik
2021-12-01 18:17 ` [PATCH v2 17/22] btrfs-progs: add a btrfs_delete_and_free_root helper Josef Bacik
2021-12-01 18:17 ` [PATCH v2 18/22] btrfs-progs: make btrfs_clear_free_space_tree extent tree v2 aware Josef Bacik
2021-12-01 18:17 ` [PATCH v2 19/22] btrfs-progs: make btrfs_create_tree take a key for the root key Josef Bacik
2021-12-01 18:17 ` [PATCH v2 20/22] btrfs-progs: mkfs: set chunk_item_objectid properly for extent tree v2 Josef Bacik
2021-12-01 18:17 ` [PATCH v2 21/22] btrfs-progs: mkfs: create the global root's Josef Bacik
2021-12-01 18:17 ` [PATCH v2 22/22] btrfs-progs: check: don't do the root item check for extent tree v2 Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbdfe7c345af59922480ffabbcf045d75aac9202.1638382588.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.