From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Sylwester Nawrocki <snawrocki@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] clk: samsung: exynos542x: Move MSCL subsystem clocks to its sub-CMU
Date: Thu, 8 Aug 2019 17:11:44 +0200 [thread overview]
Message-ID: <cc516c44-862c-ab83-84ad-67e90e088067@samsung.com> (raw)
In-Reply-To: <20190808121839.23892-1-m.szyprowski@samsung.com>
On 8/8/19 14:18, Marek Szyprowski wrote:
> M2M scaler clocks require special handling of their parent bus clock during
> power domain on/off sequences. MSCL clocks were not initially added to the
> sub-CMU handler, because that time there was no driver for the M2M scaler
> device and it was not possible to test it.
>
> This patch fixes this issue. Parent clock for M2M scaler devices is now
> properly preserved during MSC power domain on/off sequence. This gives M2M
> scaler devices proper performance: fullHD XRGB32 image 1000 rotations test
> takes 3.17s instead of 45.08s.
>
> Fixes: b06a532bf1fa ("clk: samsung: Add Exynos5 sub-CMU clock driver")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Stephen, could you apply this patch directly to clk-fixes, on top of
my patches:
[v2,2/2] clk: samsung: exynos5800: Move MAU subsystem clocks to MAU sub-CMU
[v2,1/2] clk: samsung: Change signature of exynos5_subcmus_init() function
? Regression that these 3 patches are fixing is not new, it has been
introduced much earlier than 5.3-rc1, however it's quite serious and it
would be good to have the fixes already in 5.3 release.
If that's your preference I will just queue these patches for coming
merge window.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2019-08-08 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190808121846eucas1p12022cc4a5c23af44e46c459a0c3c5746@eucas1p1.samsung.com>
2019-08-08 12:18 ` [PATCH] clk: samsung: exynos542x: Move MSCL subsystem clocks to its sub-CMU Marek Szyprowski
2019-08-08 15:11 ` Sylwester Nawrocki [this message]
2019-08-08 20:16 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc516c44-862c-ab83-84ad-67e90e088067@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.