Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting

From: Michal Simek <michal.simek@xilinx.com>
To: Moritz Fischer <moritz.fischer@ettus.com>, Alan Tull <atull@kernel.org>
Cc: "Michal Simek" <michal.simek@xilinx.com>,
	linux-fpga@vger.kernel.org,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] fpga: Add flag to indicate bitstream needs decrypting
Date: Wed, 15 Feb 2017 19:07:37 +0100	[thread overview]
Message-ID: <cc914f09-662a-e47d-d399-08036ee2e17c@xilinx.com> (raw)
In-Reply-To: <CAAtXAHfkiRYD68BRydFFd4OmdHaf9A+kmyOLkH0qNM8VL7G2Og@mail.gmail.com>

On 15.2.2017 19:02, Moritz Fischer wrote:
> On Wed, Feb 15, 2017 at 5:30 PM, Alan Tull <atull@kernel.org> wrote:
>> On Wed, Feb 15, 2017 at 9:03 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> 
>>>>  #define FPGA_MGR_PARTIAL_RECONFIG    BIT(0)
>>>>  #define FPGA_MGR_EXTERNAL_CONFIG     BIT(1)
>>>> +#define FPGA_MGR_DECRYPT_BITSTREAM   BIT(2)
>>>>
>>>>  /**
>>>>   * struct fpga_image_info - information specific to a FPGA image
>>>>
>>>
>>> Isn't it better to state that bitstream is encrypted
>>> instead of saying that bitstream requires decryption?
>>
>> Such as FPGA_MGR_ENCRYPTED_BITSTREAM  ?
> 
> Yeah, can do. This was basically a 'redo' of my earlier 'capability' based
> patchset. There it made more sense to have a 'can decrypt' capability.

Just keep in your mind that there are use cases where you also need to
pass keys.

Thanks,
Michal