From: Andrew Jeffery <andrew@aj.id.au>
To: Rusty Russell <rusty@rustcorp.com.au>, ccan@lists.ozlabs.org
Subject: Re: Annoying warning, a.k.a. how to add to CFLAGS
Date: Tue, 05 Sep 2017 11:15:14 +1000 [thread overview]
Message-ID: <1504574114.28363.1.camel@aj.id.au> (raw)
In-Reply-To: <87ingz7015.fsf@rustcorp.com.au>
[-- Attachment #1.1: Type: text/plain, Size: 1201 bytes --]
On Mon, 2017-09-04 at 10:27 +0930, Rusty Russell wrote:
> > Ian Zimmerman <itz@very.loosely.org> writes:
> > When I checkout current master, run ./tools/configurator/configurator >
> > config.h and then make, I get exactly 1 warning for the whole thing:
> >
> > ccan/strgrp/strgrp.c: In function ‘grp_for’:
> > ccan/strgrp/strgrp.c:296:0: warning: ignoring #pragma omp parallel [-Wunknown-pragmas]
> > #pragma omp parallel for schedule(dynamic)
> >
> > I figured out that I can silence that by adding -fopenmp to my CFLAGS.
> > But how to do that permanently? I don't want to specify that on the
> > command line every time, and I also don't want to set it in the
> > environment because sometimes I compile other things than ccan ;-)
>
> Hmm, well, if you're compiling strgrp, you should be adding CFLAGS
> from _info, which sets this correctly.
>
> In this case, we could just test defined(_OPENMP) instead of
> HAVE_OPENMP, though, which would automagically work.
Yeah, I was never really happy with what I did with HAVE_OPENMP, and I
don't recall why I did it. I'd be happy with a patch implementing
Rusty's suggestion of #if defined(_OPENMP).
Andrew
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan
prev parent reply other threads:[~2017-09-05 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 3:23 Annoying warning, a.k.a. how to add to CFLAGS Ian Zimmerman
2017-09-01 5:11 ` David Gibson
2017-09-01 11:46 ` Rhys Ulerich
2017-09-04 0:57 ` Rusty Russell
2017-09-05 1:15 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504574114.28363.1.camel@aj.id.au \
--to=andrew@aj.id.au \
--cc=ccan@lists.ozlabs.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).