All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: "Das, Nirmoy" <nirmoy.das@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Kenneth Graunke <kenneth@whitecape.org>,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 09/10] drm/i915: turn on small BAR support
Date: Tue, 21 Jun 2022 11:34:01 +0200	[thread overview]
Message-ID: <ccb7b41555d2d3cd29baa8bed840567451a6d83f.camel@linux.intel.com> (raw)
In-Reply-To: <20680d19-2b2c-583e-ce79-032f0a21e128@linux.intel.com>

On Tue, 2022-06-21 at 11:05 +0200, Das, Nirmoy wrote:
> 
> On 6/21/2022 10:38 AM, Matthew Auld wrote:
> > On 17/06/2022 13:33, Thomas Hellström wrote:
> > > 
> > > On 5/25/22 20:43, Matthew Auld wrote:
> > > > With the uAPI in place we should now have enough in place to
> > > > ensure a
> > > > working system on small BAR configurations.
> > > > 
> > > > Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> > > > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > > > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
> > > > Cc: Jon Bloomfield <jon.bloomfield@intel.com>
> > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > > > Cc: Kenneth Graunke <kenneth@whitecape.org>
> > > > Cc: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
> > > > ---
> > > >   drivers/gpu/drm/i915/gt/intel_region_lmem.c | 10 ++++------
> > > >   1 file changed, 4 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c 
> > > > b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> > > > index e9c12e0d6f59..6c6f8cbd7321 100644
> > > > --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> > > > +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> > > > @@ -111,12 +111,6 @@ static struct intel_memory_region 
> > > > *setup_lmem(struct intel_gt *gt)
> > > >           flat_ccs_base = intel_gt_read_register(gt, 
> > > > XEHPSDV_FLAT_CCS_BASE_ADDR);
> > > >           flat_ccs_base = (flat_ccs_base >>
> > > > XEHPSDV_CCS_BASE_SHIFT) 
> > > > * SZ_64K;
> > > > -        /* FIXME: Remove this when we have small-bar enabled
> > > > */
> > > > -        if (pci_resource_len(pdev, 2) < lmem_size) {
> > > > -            drm_err(&i915->drm, "System requires small-BAR
> > > > support, 
> > > > which is currently unsupported on this kernel\n");
> > > > -            return ERR_PTR(-EINVAL);
> > > > -        }
> > > > -
> > > >           if (GEM_WARN_ON(lmem_size < flat_ccs_base))
> > > >               return ERR_PTR(-EIO);
> > > > @@ -169,6 +163,10 @@ static struct intel_memory_region 
> > > > *setup_lmem(struct intel_gt *gt)
> > > >       drm_info(&i915->drm, "Local memory available: %pa\n",
> > > >            &lmem_size);
> > > > +    if (io_size < lmem_size)
> > > > +        drm_info(&i915->drm, "Using a reduced BAR size of
> > > > %lluMiB. 
> > > > Consider enabling the full BAR size if available in the
> > > > BIOS.\n",
> > > > +             (u64)io_size >> 20);
> > > > +
> > > 
> > > Hmm. I wonder what BIOS uis typically call the mappable portion
> > > of 
> > > VRAM. I'll se if I can check that on my DG1 system. Might be that
> > > an 
> > > average user misinterprets "full BAR".
> > 
> > "PCI Subsystem settings" -> "Above 4G memory [enabled/disabled]"
> > 
> > Sample size of one though.
> > 
> > Maybe s/full BAR size/full memory size/ ?
> 
> 
> Or  s/full BAR size/re-sizable BAR/
> 
> In newer BIOS, there is a more direct option to enable re-sizable
> bar: 
> "Re-Size BAR"/"Resizable BAR".

A quick googling turns up "Resizable BAR". My Asus Bios on the DG1
machine says "ReSize BAR (Resizable BAR support to harness full GPU
memory)".

So "Resizable BAR" should hopefully be understood by most people. Not
sure though if this is the same as "Above 4G memory", although the
latter must be a prerequisite I assume. 

/Thomas



> 
> 
> Nirmoy
> 
> > 
> > > 
> > > /Thomas
> > > 
> > > 
> > > 
> > > >       return mem;
> > > >   err_region_put:



  reply	other threads:[~2022-06-21  9:34 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 18:43 [PATCH 00/10] small BAR uapi bits Matthew Auld
2022-05-25 18:43 ` [Intel-gfx] " Matthew Auld
2022-05-25 18:43 ` [PATCH 01/10] drm/doc: add rfc section for small BAR uapi Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-06-16 11:18   ` Thomas Hellström (Intel)
2022-05-25 18:43 ` [PATCH 02/10] drm/i915/uapi: add probed_cpu_visible_size Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-06-01 12:36   ` Das, Nirmoy
2022-06-01 12:36     ` [Intel-gfx] " Das, Nirmoy
2022-06-16 11:22   ` Thomas Hellström (Intel)
2022-05-25 18:43 ` [PATCH 03/10] drm/i915/uapi: expose the avail tracking Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-05-26  2:44   ` kernel test robot
2022-05-26  7:58   ` Tvrtko Ursulin
2022-05-26  7:58     ` [Intel-gfx] " Tvrtko Ursulin
2022-05-26  8:10     ` Matthew Auld
2022-05-26  8:10       ` [Intel-gfx] " Matthew Auld
2022-05-26  8:33       ` Tvrtko Ursulin
2022-05-26  8:33         ` [Intel-gfx] " Tvrtko Ursulin
2022-05-30 17:05         ` Matthew Auld
2022-05-30 17:05           ` [Intel-gfx] " Matthew Auld
2022-05-25 18:43 ` [PATCH 04/10] drm/i915: remove intel_memory_region avail Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-06-17 12:16   ` Thomas Hellström
2022-05-25 18:43 ` [PATCH 05/10] drm/i915/uapi: apply ALLOC_GPU_ONLY by default Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-05-25 18:43 ` [PATCH 06/10] drm/i915/uapi: add NEEDS_CPU_ACCESS hint Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-06-01 12:30   ` Das, Nirmoy
2022-06-17 14:30   ` Thomas Hellström (Intel)
2022-05-25 18:43 ` [PATCH 07/10] drm/i915/error: skip non-mappable pages Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-06-01 12:30   ` Das, Nirmoy
2022-06-17 14:26   ` Thomas Hellström (Intel)
2022-05-25 18:43 ` [PATCH 08/10] drm/i915/uapi: disable capturing objects on recoverable contexts Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-05-26  0:08   ` kernel test robot
2022-05-26  0:08     ` kernel test robot
2022-06-17 12:28   ` Thomas Hellström (Intel)
2022-05-25 18:43 ` [PATCH 09/10] drm/i915: turn on small BAR support Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-06-17 12:33   ` Thomas Hellström
2022-06-21  8:38     ` Matthew Auld
2022-06-21  9:05       ` Das, Nirmoy
2022-06-21  9:34         ` Thomas Hellström [this message]
2022-05-25 18:43 ` [PATCH 10/10] HAX: force small BAR on dg2 Matthew Auld
2022-05-25 18:43   ` [Intel-gfx] " Matthew Auld
2022-05-25 19:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for small BAR uapi bits Patchwork
2022-05-25 19:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-05-25 20:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-26 10:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccb7b41555d2d3cd29baa8bed840567451a6d83f.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kenneth@whitecape.org \
    --cc=matthew.auld@intel.com \
    --cc=nirmoy.das@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.