Re: [PATCH] siw: Fix potential NULL pointer in siw_connect().

From: Doug Ledford <dledford@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Dan Carpenter <dan.carpenter@oracle.com>
Cc: Bernard Metzler <bmt@zurich.ibm.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] siw: Fix potential NULL pointer in siw_connect().
Date: Thu, 22 Aug 2019 11:02:43 -0400	[thread overview]
Message-ID: <ccd7df7a3062c7db10480b411ee7bdcdbbb95cea.camel@redhat.com> (raw)
In-Reply-To: <20190822120211.GA8339@ziepe.ca>

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

On Thu, 2019-08-22 at 09:02 -0300, Jason Gunthorpe wrote:
> On Thu, Aug 22, 2019 at 10:10:23AM +0300, Dan Carpenter wrote:
> 
> > > People using 'git log --oneline' should have terminals wider than
> > > 80
> > > :)
> > > 
> > > The bigger question is if the first character after the subject
> > > tag
> > > should be uppper case or lower case <hum>
> > 
> > I feel like more and more people are moving to upper case.  There
> > are
> > some people who insist on upper case and no one who insists on lower
> > case so it's easier to just make everything upper case.
> 
> I've noticed Andrew lower cases everything going through his
> tree. I've always used upper case for no prarticular reason

I prefer uppercase for the subsystem, and lowercase for the component.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]