From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Ian Jackson" <iwj@xenproject.org>, "Wei Liu" <wl@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Christopher Clark" <christopher.w.clark@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 03/12] xen: harmonize return types of hypercall handlers
Date: Mon, 18 Oct 2021 17:31:25 +0200 [thread overview]
Message-ID: <ccff48c8-2602-d9e1-09c2-bb8ea34199b6@suse.com> (raw)
In-Reply-To: <838aace7-8076-3c78-cb53-faef04162568@suse.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1032 bytes --]
On 18.10.21 16:25, Jan Beulich wrote:
> On 18.10.2021 15:24, Juergen Gross wrote:
>> On 18.10.21 13:55, Jan Beulich wrote:
>>> On 15.10.2021 14:51, Juergen Gross wrote:
>>>> Change the type of the cmd parameter for [do|compat]_kexec_op() to
>>>> unsigned int, as this is more appropriate for the compat case.
>>>
>>> The change for the compat case is fine, but for native you change
>>> behavior for callers passing values equaling valid KEXEC_CMD_*
>>> modulo 2³².
>>
>> TBH, I don't think this is really a problem. Or do you think there
>> really is a user of this interface relying on a -ENOSYS in this
>> case?
>
> That's a secondary consideration of mine only. The primary one is
> that invoking with an invalid sub-op should fail, such that in the
> future we can assign meaning to the upper bits, if need be. See
> their use for continuations in memory-op, for example.
But this would mean to exclude such usage of upper bits for 32 bit
systems in case this difference should matter.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-10-18 15:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 12:51 [PATCH 00/12] xen: drop hypercall function tables Juergen Gross
2021-10-15 12:51 ` [PATCH 01/12] xen: limit number of hypercall parameters to 5 Juergen Gross
2021-10-15 12:51 ` [PATCH 02/12] xen: move do_vcpu_op() to arch specific code Juergen Gross
2021-10-15 12:51 ` [PATCH 03/12] xen: harmonize return types of hypercall handlers Juergen Gross
2021-10-18 11:55 ` Jan Beulich
2021-10-18 13:24 ` Juergen Gross
2021-10-18 14:25 ` Jan Beulich
2021-10-18 15:31 ` Juergen Gross [this message]
2021-10-15 12:51 ` [PATCH 04/12] xen/x86: modify hvm_memory_op() prototype Juergen Gross
2021-10-18 12:31 ` Jan Beulich
2021-10-18 13:27 ` Juergen Gross
2021-10-18 14:28 ` Jan Beulich
2021-10-18 15:34 ` Juergen Gross
2021-10-15 12:51 ` [PATCH 05/12] xen: don't include asm/hypercall.h from C sources Juergen Gross
2021-10-18 12:39 ` Jan Beulich
2021-10-18 15:20 ` Juergen Gross
2021-10-15 12:51 ` [PATCH 06/12] xen: generate hypercall interface related code Juergen Gross
2021-10-18 12:58 ` Jan Beulich
2021-10-18 15:28 ` Juergen Gross
2021-10-18 15:39 ` Jan Beulich
2021-10-20 7:02 ` Juergen Gross
2021-10-20 7:11 ` Jan Beulich
2021-10-20 7:18 ` Juergen Gross
2021-10-15 12:51 ` [PATCH 07/12] xen: use generated prototypes for hypercall handlers Juergen Gross
2021-10-18 13:01 ` Jan Beulich
2021-10-15 12:51 ` [PATCH 08/12] x86/pv-shim: don't modify hypercall table Juergen Gross
2021-10-15 13:57 ` Jan Beulich
2021-10-15 14:23 ` Juergen Gross
2021-10-15 12:51 ` [PATCH 09/12] xen/x86: don't use hypercall table for calling compat hypercalls Juergen Gross
2021-10-15 12:51 ` [PATCH 10/12] xen/x86: call hypercall handlers via switch statement Juergen Gross
2021-10-21 14:41 ` Jan Beulich
2021-10-28 14:32 ` Juergen Gross
2021-11-02 9:54 ` Jan Beulich
2021-11-02 10:04 ` Juergen Gross
2021-10-15 12:51 ` [PATCH 11/12] xen/arm: " Juergen Gross
2021-10-15 12:51 ` [PATCH 12/12] xen/x86: add hypercall performance counters for hvm, correct pv Juergen Gross
2021-10-21 15:19 ` Jan Beulich
2021-10-28 14:35 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccff48c8-2602-d9e1-09c2-bb8ea34199b6@suse.com \
--to=jgross@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=christopher.w.clark@gmail.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.