Re: [dm-devel] [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd)

From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
	linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd)
Date: Wed, 8 Nov 2017 11:08:13 -0700	[thread overview]
Message-ID: <cd9e59d1-5619-5985-6938-e08ad4ccb40c@kernel.dk> (raw)
In-Reply-To: <20171108180358.GA6724@infradead.org>

On 11/08/2017 11:03 AM, Christoph Hellwig wrote:
> On Wed, Nov 08, 2017 at 08:36:25AM -0700, Jens Axboe wrote:
>> On 11/08/2017 08:34 AM, Christoph Hellwig wrote:
>>> On Wed, Nov 08, 2017 at 08:20:58AM -0700, Jens Axboe wrote:
>>>> On top of that, there are no users of it at all...
>>>
>>> But Mikulas wants to add one :)
>>
>> I know...
>>
>>> Note that __bio_kmap_atomic has the same issues, only has a single
>>> users either and would be cleaner if opencoded there as it already
>>> has the current bvec.  See patch below.
>>
>> Kill them all with fire. The open coded version is much clearer.
> 
> Feel free to throw the patch in under either your or my name.

I'll do a combo. Just checking if it's OK I add your signed-off-by
to the patch, I don't want something with you as an author, but
not having an SOB.

-- 
Jens Axboe