From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 0/4] xfs: enable per-type quota timers and warn limits
Date: Tue, 18 Feb 2020 15:07:43 -0600 [thread overview]
Message-ID: <ce37ab22-9864-e45c-eeb6-889dbe76169e@sandeen.net> (raw)
In-Reply-To: <20200218044934.GA14282@dhcp-12-102.nay.redhat.com>
On 2/17/20 10:49 PM, Zorro Lang wrote:
> On Sat, Feb 08, 2020 at 03:09:19PM -0600, Eric Sandeen wrote:
>> Quota timers are currently a mess. Right now, at mount time,
>> we pick up the first enabled type and use that for the single
>> timer in mp->m_quotainfo.
>>
>> Interestingly, if we set a timer on a different type, /that/
>> gets set into mp->m_quotainfo where it stays in effect until
>> the next mount, when we pick the first enabled type again.
>>
>> We actually write the timer values to each type of quota inode,
>> but only one is ever in force, according to the interesting behavior
>> described above.
>>
>> This series allows quota timers & warn limits to be independently
>> set and enforced for each quota type.
>>
>> All the action is in the last patch, the first 3 are cleanups to
>> help.
>
> This patchset looks good, but the testing for xfs quota timers looks
> not so well. Please check the emails(test case) I sent to fstests@:
> [PATCH 1/2] generic: per-type quota timers set/get test
> [PATCH 2/2] generic: test per-type quota softlimit enforcement timeout
>
> Why xfs has such different test results? Please feel free to tell me,
> if the case is wrong.
Thanks for this, Zorro, I'll take a look.
-Eric
> Thanks,
> Zorro
>
>>
>> -Eric
>>
>
prev parent reply other threads:[~2020-02-18 21:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 21:09 [PATCH 0/4] xfs: enable per-type quota timers and warn limits Eric Sandeen
2020-02-08 21:10 ` [PATCH 1/4] xfs: fix up some whitespace in quota code Eric Sandeen
2020-02-11 5:30 ` Allison Collins
2020-02-17 13:37 ` Christoph Hellwig
2020-02-08 21:11 ` [PATCH 2/4] xfs: simplify args to xfs_get_defquota Eric Sandeen
2020-02-11 5:30 ` Allison Collins
2020-02-17 13:38 ` Christoph Hellwig
2020-02-18 20:16 ` Eric Sandeen
2020-02-08 21:11 ` [PATCH 3/4] xfs: pass xfs_dquot to xfs_qm_adjust_dqtimers Eric Sandeen
2020-02-11 5:30 ` Allison Collins
2020-02-17 13:38 ` Christoph Hellwig
2020-02-08 21:12 ` [PATCH 4/4] xfs: per-type quota timers and warn limits Eric Sandeen
2020-02-11 5:30 ` Allison Collins
2020-02-17 13:43 ` Christoph Hellwig
2020-02-17 16:03 ` Eric Sandeen
2020-02-08 21:12 ` [PATCH 0/4] xfs: enable " Eric Sandeen
2020-02-11 15:43 ` Darrick J. Wong
2020-02-11 15:52 ` Eric Sandeen
2020-02-11 21:40 ` Eric Sandeen
2020-02-18 4:49 ` Zorro Lang
2020-02-18 21:07 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce37ab22-9864-e45c-eeb6-889dbe76169e@sandeen.net \
--to=sandeen@sandeen.net \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.