Re: [PATCH -next] platform/x86/dell-wmi-sysman: Make wmi_sysman_kobj_sysfs_ops static

From: Hans de Goede <hdegoede@redhat.com>
To: Zou Wei <zou_wei@huawei.com>, mgross@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] platform/x86/dell-wmi-sysman: Make wmi_sysman_kobj_sysfs_ops static
Date: Tue, 3 Nov 2020 10:35:47 +0100	[thread overview]
Message-ID: <ce524fef-d866-9f31-85e7-4ae22a51859a@redhat.com> (raw)
In-Reply-To: <1603971581-64135-1-git-send-email-zou_wei@huawei.com>

Hi,

On 10/29/20 12:39 PM, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/platform/x86/dell-wmi-sysman/sysman.c:258:24: warning:
> symbol 'wmi_sysman_kobj_sysfs_ops' was not declared.
> Should it be static?
> 
> wmi_sysman_kobj_sysfs_ops has only call within sysman.c
> It should be static
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/dell-wmi-sysman/sysman.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell-wmi-sysman/sysman.c
> index 3842575..c6862c3 100644
> --- a/drivers/platform/x86/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell-wmi-sysman/sysman.c
> @@ -255,7 +255,7 @@ static ssize_t wmi_sysman_attr_store(struct kobject *kobj, struct attribute *att
>  	return ret;
>  }
>  
> -const struct sysfs_ops wmi_sysman_kobj_sysfs_ops = {
> +static const struct sysfs_ops wmi_sysman_kobj_sysfs_ops = {
>  	.show	= wmi_sysman_attr_show,
>  	.store	= wmi_sysman_attr_store,
>  };
> 