From: Guenter Roeck <linux@roeck-us.net>
To: Ivor Wanders <ivor@iwanders.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maximilian Luz <luzmaximilian@gmail.com>
Subject: Re: [PATCH 0/1] clarify intent of fan min and max attributes
Date: Fri, 22 Dec 2023 08:12:50 -0800 [thread overview]
Message-ID: <ce60c838-0fad-4bb4-8af4-a94d43092d4d@roeck-us.net> (raw)
In-Reply-To: <20231221225149.11295-1-ivor@iwanders.net>
On Thu, Dec 21, 2023 at 05:51:48PM -0500, Ivor Wanders wrote:
> In [1] I got the feedback that fan min and max attributes are intended for
> writing to the device and not merely providing constants to userspace.
> This patch clarifies this intent in the documentation such that future
> contributers don't make incorrect assumptions about them.
>
Documentation/hwmon/sysfs-interface already states:
"
All entries (except name) are optional, and should only be created in a
given driver if the chip has the feature.
"
I do not see the point of clarifying this for individual attributes,
especially since that might create the impression that it would possibly
not apply to other attributes (for those not reading the above
documentation).
Guenter
next prev parent reply other threads:[~2023-12-22 16:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 22:51 [PATCH 0/1] clarify intent of fan min and max attributes Ivor Wanders
2023-12-21 22:51 ` [PATCH 1/1] hwmon: clarify intent of fan min/max Ivor Wanders
2023-12-21 23:19 ` Randy Dunlap
2023-12-21 23:31 ` [PATCH v2] " Ivor Wanders
2023-12-21 23:38 ` Randy Dunlap
2023-12-21 23:46 ` Ivor Wanders
2023-12-22 16:14 ` Guenter Roeck
2023-12-22 23:20 ` Ivor Wanders
2023-12-22 16:12 ` Guenter Roeck [this message]
2023-12-22 23:17 ` [PATCH 0/1] clarify intent of fan min and max attributes Ivor Wanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce60c838-0fad-4bb4-8af4-a94d43092d4d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=ivor@iwanders.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.