From: Jan Kiszka <jan.kiszka@siemens.com>
To: Srinuvasan Arjunan <srinuvasan_a@mentor.com>,
cip-dev@lists.cip-project.org
Subject: Re: [isar-cip-core][PATCH] scripts/deploy-cip-core.sh: fix style issues
Date: Wed, 5 Apr 2023 11:38:57 +0200 [thread overview]
Message-ID: <ce6d8f5c-d703-3898-9839-7dd8c77d3e74@siemens.com> (raw)
In-Reply-To: <20230405071927.600015-1-srinuvasan_a@mentor.com>
On 05.04.23 09:19, Srinuvasan Arjunan wrote:
> From: Srinuvasan A <srinuvasan_a@mentor.com>
>
> Align same coding style with other scripts.
>
> Signed-off-by: Srinuvasan A <srinuvasan_a@mentor.com>
> ---
> scripts/deploy-cip-core.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/deploy-cip-core.sh b/scripts/deploy-cip-core.sh
> index ab98468..b185a84 100755
> --- a/scripts/deploy-cip-core.sh
> +++ b/scripts/deploy-cip-core.sh
> @@ -17,8 +17,8 @@ DTB=$4
> REF=$5
>
> BASE_FILENAME=cip-core-image-cip-core-$RELEASE-$TARGET
> -if [ "${EXTENSION}" != "none" ] ; then
> - if [ "${EXTENSION}" = "security" ] ; then
> +if [ "${EXTENSION}" != "none" ]; then
> + if [ "${EXTENSION}" = "security" ]; then
> BASE_FILENAME=cip-core-image-$EXTENSION-cip-core-$RELEASE-$TARGET
> else
> BASE_FILENAME=cip-core-image-cip-core-$RELEASE-$TARGET-$EXTENSION
> @@ -28,7 +28,7 @@ fi
> BASE_PATH=build/tmp/deploy/images/$TARGET/$BASE_FILENAME
> S3_TARGET=s3://download2.cip-project.org/cip-core/$REF/$TARGET/
>
> -if [ -f $BASE_PATH.wic ] ; then
> +if [ -f $BASE_PATH.wic ]; then
> echo "Compressing $BASE_FILENAME.wic..."
> xz -9 -k -T0 $BASE_PATH.wic
>
Thanks, applied.
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
prev parent reply other threads:[~2023-04-05 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 7:19 [isar-cip-core][PATCH] scripts/deploy-cip-core.sh: fix style issues Srinuvasan Arjunan
2023-04-05 9:38 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce6d8f5c-d703-3898-9839-7dd8c77d3e74@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=cip-dev@lists.cip-project.org \
--cc=srinuvasan_a@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.