Re: [PATCH 2/2] kbuild: modversions for exported asm symbols

From: Michal Marek <mmarek@suse.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 2/2] kbuild: modversions for exported asm symbols
Date: Tue, 1 Nov 2016 15:21:28 +0100	[thread overview]
Message-ID: <ced5a533-6ce9-642d-fc07-4fd9d99ff6af@suse.com> (raw)
In-Reply-To: <bd7b413a-3290-b9cc-35c2-09b22bc2ef71@suse.com>

On 2016-11-01 15:19, Michal Marek wrote:
> On 2016-10-31 12:14, Nicholas Piggin wrote:
>> +# This is convoluted. The .S file must first be preprocessed to run guards and
>> +# expand names, then the resulting exports must be constructed into plain
>> +# EXPORT_SYMBOL(symbol); to build our dummy C file, and that gets preprocessed
>> +# to make the genksyms input.
>>  #
>>  # These mirror gensymtypes_c and co above, keep them in synch.
>>  cmd_gensymtypes_S =                                                         \
>>      (echo "\#include <linux/kernel.h>" ;                                    \
>>       echo "\#include <asm/asm-prototypes.h>" ;                              \
>> -     grep EXPORT_SYMBOL $< | sed 's/$$/;/' ) |                              \
>> +    $(CPP) $(a_flags) $< |                                                  \
>> +     grep ^___EXPORT_SYMBOL |                                               \
>> +     sed 's/___EXPORT_SYMBOL \([a-zA-Z0-9_]*\),.*/EXPORT_SYMBOL(\1);/' ) |  \
> 
> Is this sed pass necessary? Just add -D__GENKSYMS__ also to the first
> cpp run and EXPORT_SYMBOL will stay intact.
> 
> Anyway, I'm going to merge your patch 2/2 now.

Now I noticed you posted a combined patch today. What do you thing about
removing the sed call in favor of -D__GENKSYMS__?

Thanks,
Michal