From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Mathias Nyman <mathias.nyman@linux.intel.com>, rydberg@bitmath.org
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] Input: bcm5974 - Set missing URB_NO_TRANSFER_DMA_MAP urb flag
Date: Tue, 7 Jun 2022 11:21:53 +0200 [thread overview]
Message-ID: <cef04dbd-985a-c0d5-4c8b-7e234daa402a@leemhuis.info> (raw)
In-Reply-To: <20220606113636.588955-1-mathias.nyman@linux.intel.com>
On 06.06.22 13:36, Mathias Nyman wrote:
> The bcm5974 driver does the allocation and dma mapping of the usb urb
> data buffer, but driver does not set the URB_NO_TRANSFER_DMA_MAP flag
> to let usb core know the buffer is already mapped.
>
> usb core tries to map the already mapped buffer, causing a warning:
> "xhci_hcd 0000:00:14.0: rejecting DMA map of vmalloc memory"
>
> Fix this by setting the URB_NO_TRANSFER_DMA_MAP, letting usb core
> know buffer is already mapped by bcm5974 driver
BTW @reviewers & @maintainers: this is fixing a regression, hence please
prioritize this. For details see "Prioritize work on fixing regressions"
in Documentation/process/handling-regressions.rst or
docs.kernel.org/process/handling-regressions.html .
> Cc: stable@vger.kernel.org
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
If you need to respin this for one reason or another, could you please
add proper 'Link:' tags pointing to all reports about this issue? e.g.
like this:
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215890
These tags are important, as they allow others to look into the
backstory now and years from now. That is why they should be placed in
cases like this, as Documentation/process/submitting-patches.rst and
Documentation/process/5.Posting.rst explain in more detail.
Additionally, my regression tracking bot ‘regzbot’ relies on these tags
to automatically connect reports with patches that are posted or
committed to fix the reported issue.
> [...]
Ciao, Thorsten
prev parent reply other threads:[~2022-06-07 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 11:36 [PATCH] Input: bcm5974 - Set missing URB_NO_TRANSFER_DMA_MAP urb flag Mathias Nyman
2022-06-07 9:21 ` Thorsten Leemhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef04dbd-985a-c0d5-4c8b-7e234daa402a@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rydberg@bitmath.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.