From: Jeff Layton <jlayton@kernel.org>
To: xiubli@redhat.com
Cc: idryomov@gmail.com, pdonnell@redhat.com, ceph-devel@vger.kernel.org
Subject: Re: [PATCH] ceph: fix a typo in comments
Date: Mon, 05 Apr 2021 07:30:43 -0400 [thread overview]
Message-ID: <0d8435629047c4aa1820e51730273eb615a6aaa1.camel@kernel.org> (raw)
In-Reply-To: <20210329045904.135183-1-xiubli@redhat.com>
On Mon, 2021-03-29 at 12:59 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
> fs/ceph/addr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 57c67180ce5c..5b66f17afe0c 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1945,7 +1945,7 @@ int ceph_pool_perm_check(struct inode *inode, int need)
> if (ci->i_vino.snap != CEPH_NOSNAP) {
> /*
> * Pool permission check needs to write to the first object.
> - * But for snapshot, head of the first object may have alread
> + * But for snapshot, head of the first object may have already
> * been deleted. Skip check to avoid creating orphan object.
> */
> return 0;
In general, I don't like to merge patches that just change comments
without other substantive changes. I did make an exception in this
patch:
[PATCH 1/2] ceph: fix kerneldoc copypasta over ceph_start_io_direct
...but that was mainly because that was generating a warning at build-
time for me. I'm going to drop this patch for now.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2021-04-05 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 4:59 [PATCH] ceph: fix a typo in comments xiubli
2021-04-05 11:30 ` Jeff Layton [this message]
2021-04-06 0:43 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d8435629047c4aa1820e51730273eb615a6aaa1.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=pdonnell@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).