ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: dhowells@redhat.com, Jeff Layton <jlayton@kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com,
	linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org,
	linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org,
	v9fs-developer@lists.sourceforge.net, devel@lists.orangefs.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] folio: Add a function to get the host inode for a folio
Date: Tue, 24 Aug 2021 15:11:45 +0100	[thread overview]
Message-ID: <1951630.1629814305@warthog.procyon.org.uk> (raw)
In-Reply-To: <YST8OcVNy02Rivbm@casper.infradead.org>

Matthew Wilcox <willy@infradead.org> wrote:

> > +static inline struct inode *folio_inode(struct folio *folio)
> > +{
> > +	return folio_file_mapping(folio)->host;
> You're contradicting yourself here.  If you're allowed to call this
> function for swap cache pages, then the documentation needs to change.
> If you're not, then we can just use folio->mapping->host.

Um.  I don't know.  I'll do the latter, then, for now.


  parent reply	other threads:[~2021-08-24 14:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 13:24 [PATCH 0/6] netfs, afs, ceph: Support folios, at least partially David Howells
2021-08-24 13:24 ` [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position David Howells
2021-08-24 14:18   ` Christoph Hellwig
2021-08-24 14:18   ` Matthew Wilcox
2021-08-24 14:38   ` David Howells
2021-08-24 13:24 ` [PATCH 2/6] folio: Add a function to change the private data attached to a folio David Howells
2021-08-24 13:25 ` [PATCH 3/6] folio: Add a function to get the host inode for " David Howells
2021-08-24 14:03   ` Matthew Wilcox
2021-08-24 14:11   ` David Howells [this message]
2021-08-24 13:25 ` [PATCH 4/6] afs: Sort out symlink reading David Howells
2021-08-24 13:25 ` [PATCH 5/6] netfs, afs, ceph: Use folios David Howells
2021-08-24 13:25 ` [PATCH 6/6] afs: Use folios in directory handling David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1951630.1629814305@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=devel@lists.orangefs.org \
    --cc=idryomov@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    --cc=willy@infradead.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).